ruby-changes:9891
From: seki <ko1@a...>
Date: Sun, 11 Jan 2009 20:21:41 +0900 (JST)
Subject: [ruby-changes:9891] Ruby:r21432 (ruby_1_8): remove PercentScanner. fixed % after %> bug. [Bug #997]
seki 2009-01-11 20:21:26 +0900 (Sun, 11 Jan 2009) New Revision: 21432 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=21432 Log: remove PercentScanner. fixed % after %> bug. [ruby-dev:37751] [Bug #997] Modified files: branches/ruby_1_8/ChangeLog branches/ruby_1_8/lib/erb.rb branches/ruby_1_8/test/erb/test_erb.rb Index: ruby_1_8/ChangeLog =================================================================== --- ruby_1_8/ChangeLog (revision 21431) +++ ruby_1_8/ChangeLog (revision 21432) @@ -1,3 +1,10 @@ +Sun Jan 11 20:19:38 2009 Masatoshi SEKI <m_seki@m...> + + * lib/erb.rb (PercentScanner): remove PercentScanner. fixed % after + %> bug. [ruby-dev:37751] [Bug #997] + + * test/erb/test_erb.rb: ditto + Sun Jan 11 09:42:28 2009 Nobuyoshi Nakada <nobu@r...> * hash.c (rb_hash_s_create): set nil as the value if assoc length Index: ruby_1_8/lib/erb.rb =================================================================== --- ruby_1_8/lib/erb.rb (revision 21431) +++ ruby_1_8/lib/erb.rb (revision 21432) @@ -426,40 +426,6 @@ end Scanner.regist_scanner(SimpleScanner2, nil, false) - class PercentScanner < Scanner # :nodoc: - def scan(&blk) - stag_reg = /(.*?)(^%%|^%|<%%|<%=|<%#|<%|\z)/m - etag_reg = /(.*?)(%%>|%>|\z)/m - scanner = StringScanner.new(@src) - while ! scanner.eos? - scanner.scan(@stag ? etag_reg : stag_reg) - yield(scanner[1]) - - elem = scanner[2] - if elem == '%%' - yield('%') - inline_scan(scanner.scan(/.*?(\n|\z)/), &blk) - elsif elem == '%' - yield(PercentLine.new(scanner.scan(/.*?(\n|\z)/).chomp)) - else - yield(elem) - end - end - end - - def inline_scan(line) - stag_reg = /(.*?)(<%%|<%=|<%#|<%|\z)/m - etag_reg = /(.*?)(%%>|%>|\z)/m - scanner = StringScanner.new(line) - while ! scanner.eos? - scanner.scan(@stag ? etag_reg : stag_reg) - yield(scanner[1]) - yield(scanner[2]) - end - end - end - Scanner.regist_scanner(PercentScanner, nil, true) - class ExplicitScanner < Scanner # :nodoc: def scan stag_reg = /(.*?)(^[ \t]*<%-|<%%|<%=|<%#|<%-|<%|\z)/m Index: ruby_1_8/test/erb/test_erb.rb =================================================================== --- ruby_1_8/test/erb/test_erb.rb (revision 21431) +++ ruby_1_8/test/erb/test_erb.rb (revision 21432) @@ -410,6 +410,10 @@ assert_equal(ans, ERB.new(src, nil, '-').result) assert_equal(ans, ERB.new(src, nil, '-%').result) end + + def test_percent_after_etag + assert_equal("1%", @erb.new("<%= 1 %>%", nil, "%").result) + end end class TestERBCoreWOStrScan < TestERBCore -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/