[前][次][番号順一覧][スレッド一覧]

ruby-changes:9890

From: seki <ko1@a...>
Date: Sun, 11 Jan 2009 16:58:24 +0900 (JST)
Subject: [ruby-changes:9890] Ruby:r21431 (trunk): remove PercentScanner. fixed % after %> bug. [Bug #997]

seki	2009-01-11 16:58:02 +0900 (Sun, 11 Jan 2009)

  New Revision: 21431

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=21431

  Log:
    remove PercentScanner. fixed % after %> bug. [ruby-dev:37751] [Bug #997]

  Modified files:
    trunk/ChangeLog
    trunk/lib/erb.rb
    trunk/test/erb/test_erb.rb

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 21430)
+++ ChangeLog	(revision 21431)
@@ -1,3 +1,10 @@
+Sun Jan 11 16:53:14 2009  Masatoshi SEKI  <m_seki@m...>
+
+	* lib/erb.rb (PercentScanner): remove PercentScanner. fixed % after
+	  %> bug. [ruby-dev:37751] [Bug #997] 
+
+	* test/erb/test_erb.rb: ditto
+
 Sun Jan 11 09:53:01 2009  Nobuyoshi Nakada  <nobu@r...>
 
 	* ext/socket/mkconstants.rb (c_str): get rid of a 1.9 feature for
Index: lib/erb.rb
===================================================================
--- lib/erb.rb	(revision 21430)
+++ lib/erb.rb	(revision 21431)
@@ -444,40 +444,6 @@
       end
       Scanner.regist_scanner(SimpleScanner2, nil, false)
 
-      class PercentScanner < Scanner # :nodoc:
-	def scan(&blk)
-          stag_reg = /(.*?)(^%%|^%|<%%|<%=|<%#|<%|\z)/m
-          etag_reg = /(.*?)(%%>|%>|\z)/m
-          scanner = StringScanner.new(@src)
-          while ! scanner.eos?
-	    scanner.scan(@stag ? etag_reg : stag_reg)
-            yield(scanner[1])
-
-            elem = scanner[2]
-            if elem == '%%'
-              yield('%')
-              inline_scan(scanner.scan(/.*?(\n|\z)/), &blk)
-            elsif elem == '%'
-              yield(PercentLine.new(scanner.scan(/.*?(\n|\z)/).chomp))
-            else
-              yield(elem)
-            end
-          end
-        end
-
-        def inline_scan(line)
-          stag_reg = /(.*?)(<%%|<%=|<%#|<%|\z)/m
-          etag_reg = /(.*?)(%%>|%>|\z)/m
-          scanner = StringScanner.new(line)
-          while ! scanner.eos?
-            scanner.scan(@stag ? etag_reg : stag_reg)
-            yield(scanner[1])
-            yield(scanner[2])
-          end
-        end
-      end
-      Scanner.regist_scanner(PercentScanner, nil, true)
-
       class ExplicitScanner < Scanner # :nodoc:
 	def scan
           stag_reg = /(.*?)(^[ \t]*<%-|<%%|<%=|<%#|<%-|<%|\z)/m
Index: test/erb/test_erb.rb
===================================================================
--- test/erb/test_erb.rb	(revision 21430)
+++ test/erb/test_erb.rb	(revision 21431)
@@ -442,6 +442,10 @@
     assert_equal("%A5%B5%A5%F3%A5%D7%A5%EB",
                  ERB::Util.url_encode("\xA5\xB5\xA5\xF3\xA5\xD7\xA5\xEB".force_encoding("EUC-JP")))
   end
+
+  def test_percent_after_etag
+    assert_equal("1%", @erb.new("<%= 1 %>%", nil, "%").result)
+  end
 end
 
 class TestERBCoreWOStrScan < TestERBCore

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]