ruby-changes:67549
From: aycabta <ko1@a...>
Date: Thu, 2 Sep 2021 14:07:58 +0900 (JST)
Subject: [ruby-changes:67549] 4852d87a81 (master): [ruby/reline] Fix a crash when completing empty line
https://git.ruby-lang.org/ruby.git/commit/?id=4852d87a81 From 4852d87a81ae8b7f239787bdc18560f89dd18cab Mon Sep 17 00:00:00 2001 From: aycabta <aycabta@g...> Date: Thu, 2 Sep 2021 04:43:36 +0900 Subject: [ruby/reline] Fix a crash when completing empty line https://github.com/ruby/reline/commit/8226ae7e57 --- lib/reline/line_editor.rb | 4 +++- test/reline/yamatanooroti/test_rendering.rb | 13 +++++++++++++ 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/lib/reline/line_editor.rb b/lib/reline/line_editor.rb index 9442bdf..2a1d4b4 100644 --- a/lib/reline/line_editor.rb +++ b/lib/reline/line_editor.rb @@ -1295,8 +1295,10 @@ class Reline::LineEditor https://github.com/ruby/ruby/blob/trunk/lib/reline/line_editor.rb#L1295 end end completed = @completion_journey_data.list[@completion_journey_data.pointer] - @line = (@completion_journey_data.preposing + completed + @completion_journey_data.postposing).split("\n")[@line_index] + new_line = (@completion_journey_data.preposing + completed + @completion_journey_data.postposing).split("\n")[@line_index] + @line = new_line.nil? ? String.new(encoding: @encoding) : new_line line_to_pointer = (@completion_journey_data.preposing + completed).split("\n").last + line_to_pointer = String.new(encoding: @encoding) if line_to_pointer.nil? @cursor_max = calculate_width(@line) @cursor = calculate_width(line_to_pointer) @byte_pointer = line_to_pointer.bytesize diff --git a/test/reline/yamatanooroti/test_rendering.rb b/test/reline/yamatanooroti/test_rendering.rb index 0ea5b1a..7a73f07 100644 --- a/test/reline/yamatanooroti/test_rendering.rb +++ b/test/reline/yamatanooroti/test_rendering.rb @@ -823,6 +823,19 @@ begin https://github.com/ruby/ruby/blob/trunk/test/reline/yamatanooroti/test_rendering.rb#L823 EOC end + def test_completion_journey_with_empty_line + write_inputrc <<~LINES + set editing-mode vi + LINES + start_terminal(10, 50, %W{ruby -I#{@pwd}/lib #{@pwd}/test/reline/yamatanooroti/multiline_repl --complete}, startup_message: 'Multiline REPL.') + write("\C-n\C-p") + close + assert_screen(<<~'EOC') + Multiline REPL. + prompt> + EOC + end + def write_inputrc(content) File.open(@inputrc_file, 'w') do |f| f.write content -- cgit v1.1 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/