ruby-changes:67548
From: aycabta <ko1@a...>
Date: Thu, 2 Sep 2021 14:07:58 +0900 (JST)
Subject: [ruby-changes:67548] 5f23003cc2 (master): [ruby/reline] Fix a crash when completing after 2nd line
https://git.ruby-lang.org/ruby.git/commit/?id=5f23003cc2 From 5f23003cc204182134af2682f1de1e8801b3f423 Mon Sep 17 00:00:00 2001 From: aycabta <aycabta@g...> Date: Thu, 2 Sep 2021 04:31:01 +0900 Subject: [ruby/reline] Fix a crash when completing after 2nd line https://github.com/ruby/reline/commit/f9d3480c34 --- lib/reline/line_editor.rb | 4 ++-- test/reline/yamatanooroti/multiline_repl | 5 +++++ test/reline/yamatanooroti/test_rendering.rb | 14 ++++++++++++++ 3 files changed, 21 insertions(+), 2 deletions(-) diff --git a/lib/reline/line_editor.rb b/lib/reline/line_editor.rb index 3b3fc23..9442bdf 100644 --- a/lib/reline/line_editor.rb +++ b/lib/reline/line_editor.rb @@ -1295,8 +1295,8 @@ class Reline::LineEditor https://github.com/ruby/ruby/blob/trunk/lib/reline/line_editor.rb#L1295 end end completed = @completion_journey_data.list[@completion_journey_data.pointer] - @line = @completion_journey_data.preposing + completed + @completion_journey_data.postposing - line_to_pointer = @completion_journey_data.preposing + completed + @line = (@completion_journey_data.preposing + completed + @completion_journey_data.postposing).split("\n")[@line_index] + line_to_pointer = (@completion_journey_data.preposing + completed).split("\n").last @cursor_max = calculate_width(@line) @cursor = calculate_width(line_to_pointer) @byte_pointer = line_to_pointer.bytesize diff --git a/test/reline/yamatanooroti/multiline_repl b/test/reline/yamatanooroti/multiline_repl index f2efdd4..00d4825e 100755 --- a/test/reline/yamatanooroti/multiline_repl +++ b/test/reline/yamatanooroti/multiline_repl @@ -30,6 +30,11 @@ opt.on('--dynamic-prompt-returns-empty') { https://github.com/ruby/ruby/blob/trunk/test/reline/yamatanooroti/multiline_repl#L30 opt.on('--auto-indent') { AutoIndent.new } +opt.on('--complete') { + Reline.completion_proc = lambda { |target, preposing = nil, postposing = nil| + %w{String ScriptError SyntaxError Signal} + } +} opt.parse!(ARGV) begin diff --git a/test/reline/yamatanooroti/test_rendering.rb b/test/reline/yamatanooroti/test_rendering.rb index b17e8bb..0ea5b1a 100644 --- a/test/reline/yamatanooroti/test_rendering.rb +++ b/test/reline/yamatanooroti/test_rendering.rb @@ -809,6 +809,20 @@ begin https://github.com/ruby/ruby/blob/trunk/test/reline/yamatanooroti/test_rendering.rb#L809 EOC end + def test_completion_journey_2nd_line + write_inputrc <<~LINES + set editing-mode vi + LINES + start_terminal(10, 50, %W{ruby -I#{@pwd}/lib #{@pwd}/test/reline/yamatanooroti/multiline_repl --complete}, startup_message: 'Multiline REPL.') + write("def hoge\n S\C-n") + close + assert_screen(<<~'EOC') + Multiline REPL. + prompt> def hoge + prompt> String + EOC + end + def write_inputrc(content) File.open(@inputrc_file, 'w') do |f| f.write content -- cgit v1.1 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/