[前][次][番号順一覧][スレッド一覧]

ruby-changes:55585

From: Benoit <ko1@a...>
Date: Sun, 28 Apr 2019 21:44:32 +0900 (JST)
Subject: [ruby-changes:55585] Benoit Daloze:13abf5519a (trunk): Workaround a CentOS bug in Process.clock_getres specs

https://git.ruby-lang.org/ruby.git/commit/?id=13abf5519a

From 13abf5519a8c00ac2b05409e667c58f05c75123a Mon Sep 17 00:00:00 2001
From: Benoit Daloze <eregontp@g...>
Date: Sun, 28 Apr 2019 14:39:37 +0200
Subject: Workaround a CentOS bug in Process.clock_getres specs


diff --git a/spec/ruby/core/process/clock_getres_spec.rb b/spec/ruby/core/process/clock_getres_spec.rb
index dc78fc4..5e5eb02 100644
--- a/spec/ruby/core/process/clock_getres_spec.rb
+++ b/spec/ruby/core/process/clock_getres_spec.rb
@@ -11,20 +11,24 @@ describe "Process.clock_getres" do https://github.com/ruby/ruby/blob/trunk/spec/ruby/core/process/clock_getres_spec.rb#L11
         end
         reported = Process.clock_getres(value, :nanosecond)
 
-        # The clock should not be more accurate than reported (times should be
-        # a multiple of reported precision.)
-        times.select { |t| t % reported > 0 }.should be_empty
-
-        # We're assuming precision is a multiple of ten - it may or may not
-        # be an incompatibility if it isn't but we'd like to notice this,
-        # and the spec following these wouldn't work if it isn't.
-        reported.should > 0
-        (reported == 1 || reported % 10 == 0).should be_true
-
-        # The clock should not be less accurate than reported (times should
-        # not all be a multiple of the next precision up, assuming precisions
-        # are multiples of ten.)
-        times.select { |t| t % (reported * 10) == 0  }.size.should_not == times.size
+        # CentOS seems to report a negative resolution:
+        # https://rubyci.org/logs/rubyci.s3.amazonaws.com/centos6/ruby-trunk/log/20190428T093004Z.fail.html.gz
+        unless name == :CLOCK_MONOTONIC_RAW and reported < 0
+          # The clock should not be more accurate than reported (times should be
+          # a multiple of reported precision.)
+          times.select { |t| t % reported > 0 }.should be_empty
+
+          # We're assuming precision is a multiple of ten - it may or may not
+          # be an incompatibility if it isn't but we'd like to notice this,
+          # and the spec following these wouldn't work if it isn't.
+          reported.should > 0
+          (reported == 1 || reported % 10 == 0).should be_true
+
+          # The clock should not be less accurate than reported (times should
+          # not all be a multiple of the next precision up, assuming precisions
+          # are multiples of ten.)
+          times.select { |t| t % (reported * 10) == 0  }.size.should_not == times.size
+        end
       end
     end
   end
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]