[前][次][番号順一覧][スレッド一覧]

ruby-changes:55584

From: Takashi <ko1@a...>
Date: Sun, 28 Apr 2019 21:41:22 +0900 (JST)
Subject: [ruby-changes:55584] Takashi Kokubun:14965c5f4b (trunk): Drop SVN-specific method from Merger module

https://git.ruby-lang.org/ruby.git/commit/?id=14965c5f4b

From 14965c5f4b0160d22febd94f258b2ba1491a585e Mon Sep 17 00:00:00 2001
From: Takashi Kokubun <takashikkbn@g...>
Date: Sun, 28 Apr 2019 21:40:37 +0900
Subject: Drop SVN-specific method from Merger module

to clarify it's not needed for Git support.

diff --git a/tool/merger.rb b/tool/merger.rb
index 60cb000..c78c21a 100755
--- a/tool/merger.rb
+++ b/tool/merger.rb
@@ -169,10 +169,6 @@ def remove_tag intv_p = false, relname https://github.com/ruby/ruby/blob/trunk/tool/merger.rb#L169
   system(*%w'svn rm -m', "remove tag #{tagname}", tag_url)
 end
 
-def default_merge_branch
-  %r{^URL: .*/branches/ruby_1_8_} =~ `svn info` ? 'branches/ruby_1_8' : 'trunk'
-end
-
     private
 
     # Prints the version of Ruby found in version.h
@@ -235,7 +231,6 @@ else https://github.com/ruby/ruby/blob/trunk/tool/merger.rb#L231
     tickets = ''
   end
 
-  q = $repos + (ARGV[1] || Merger.default_merge_branch)
   revstr = ARGV[0].delete('^, :\-0-9a-fA-F')
   revs = revstr.split(/[,\s]+/)
   commit_message = ''
@@ -268,9 +263,11 @@ else https://github.com/ruby/ruby/blob/trunk/tool/merger.rb#L263
       puts "+ git apply"
       IO.popen(['git', 'apply'], 'w') { |f| f.write(patch) }
     else
-      message = IO.popen(['svn', 'log', '-r', svn_rev, q], &:read)
+      default_merge_branch = (%r{^URL: .*/branches/ruby_1_8_} =~ `svn info` ? 'branches/ruby_1_8' : 'trunk')
+      svn_src = "#{$repos}#{ARGV[1] || default_merge_branch}"
+      message = IO.popen(['svn', 'log', '-r', svn_rev, svn_src], &:read)
 
-      cmd = ['svn', 'merge', '--accept=postpone', '-r', svn_rev, q]
+      cmd = ['svn', 'merge', '--accept=postpone', '-r', svn_rev, svn_src]
       puts "+ #{cmd.join(' ')}"
       system(*cmd)
     end
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]