ruby-changes:52721
From: k0kubun <ko1@a...>
Date: Sun, 7 Oct 2018 15:09:00 +0900 (JST)
Subject: [ruby-changes:52721] k0kubun:r64933 (trunk): add_spec.rb: skip unstable spec on mingw
k0kubun 2018-10-07 15:08:54 +0900 (Sun, 07 Oct 2018) New Revision: 64933 https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=64933 Log: add_spec.rb: skip unstable spec on mingw This sometimes crashes mspec worker like https://ci.appveyor.com/project/ruby/ruby/build/9806/job/37tx2atojy96227m and it doesn't generate helpful output and it seems hard to fix it soon. As AppVeyor is too unstable by too many factors, let me skip this at least for a short term. until AppVeyor gets stable. Modified files: trunk/spec/ruby/core/threadgroup/add_spec.rb Index: spec/ruby/core/threadgroup/add_spec.rb =================================================================== --- spec/ruby/core/threadgroup/add_spec.rb (revision 64932) +++ spec/ruby/core/threadgroup/add_spec.rb (revision 64933) @@ -13,24 +13,26 @@ describe "ThreadGroup#add" do https://github.com/ruby/ruby/blob/trunk/spec/ruby/core/threadgroup/add_spec.rb#L13 @thread.join end - it "adds the given thread to a group and returns self" do - @thread.group.should_not == nil + platform_is_not :mingw do + it "adds the given thread to a group and returns self" do + @thread.group.should_not == nil - tg = ThreadGroup.new - tg.add(@thread).should == tg - @thread.group.should == tg - tg.list.include?(@thread).should == true - end + tg = ThreadGroup.new + tg.add(@thread).should == tg + @thread.group.should == tg + tg.list.include?(@thread).should == true + end - it "removes itself from any other threadgroup" do - tg1 = ThreadGroup.new - tg2 = ThreadGroup.new + it "removes itself from any other threadgroup" do + tg1 = ThreadGroup.new + tg2 = ThreadGroup.new - tg1.add(@thread) - @thread.group.should == tg1 - tg2.add(@thread) - @thread.group.should == tg2 - tg2.list.include?(@thread).should == true - tg1.list.include?(@thread).should == false + tg1.add(@thread) + @thread.group.should == tg1 + tg2.add(@thread) + @thread.group.should == tg2 + tg2.list.include?(@thread).should == true + tg1.list.include?(@thread).should == false + end end end -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/