[前][次][番号順一覧][スレッド一覧]

ruby-changes:52720

From: k0kubun <ko1@a...>
Date: Sun, 7 Oct 2018 14:54:09 +0900 (JST)
Subject: [ruby-changes:52720] k0kubun:r64932 (trunk): test_jit.rb: skip some tests

k0kubun	2018-10-07 14:54:04 +0900 (Sun, 07 Oct 2018)

  New Revision: 64932

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=64932

  Log:
    test_jit.rb: skip some tests
    
    that don't succeed on MinGW after r64929

  Modified files:
    trunk/test/ruby/test_jit.rb
Index: test/ruby/test_jit.rb
===================================================================
--- test/ruby/test_jit.rb	(revision 64931)
+++ test/ruby/test_jit.rb	(revision 64932)
@@ -78,6 +78,7 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L78
   end
 
   def test_compile_insn_blockparam
+    skip_on_mingw
     skip_on_mswin
     assert_eval_with_jit("#{<<~"begin;"}\n#{<<~"end;"}", stdout: '3', success_count: 2, insns: %i[getblockparam setblockparam])
     begin;
@@ -167,10 +168,8 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L168
   end
 
   def test_compile_insn_putspecialobject_putiseq
+    skip_on_mingw # [Bug #14948]
     skip_on_mswin
-    if /mingw/ =~ RUBY_PLATFORM
-      skip "this is currently failing on MinGW [Bug #14948]"
-    end
 
     assert_eval_with_jit("#{<<~"begin;"}\n#{<<~"end;"}", stdout: 'hellohello', success_count: 2, insns: %i[putspecialobject putiseq])
     begin;
@@ -184,6 +183,7 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L183
   end
 
   def test_compile_insn_putstring_concatstrings_tostring
+    skip_on_mingw
     skip_on_mswin
     assert_compile_once('"a#{}b" + "c"', result_inspect: '"abc"', insns: %i[putstring concatstrings tostring])
   end
@@ -211,6 +211,7 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L211
   end
 
   def test_compile_insn_intern_duparray
+    skip_on_mingw
     skip_on_mswin
     assert_compile_once('[:"#{0}"] + [1,2,3]', result_inspect: '[:"0", 1, 2, 3]', insns: %i[intern duparray])
   end
@@ -357,6 +358,7 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L358
   end
 
   def test_compile_insn_invokesuper
+    skip_on_mingw
     skip_on_mswin
     assert_eval_with_jit("#{<<~"begin;"}\n#{<<~"end;"}", stdout: '3', success_count: 4, insns: %i[invokesuper])
     begin;
@@ -376,6 +378,7 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L378
   end
 
   def test_compile_insn_invokeblock_leave
+    skip_on_mingw
     skip_on_mswin
     assert_eval_with_jit("#{<<~"begin;"}\n#{<<~"end;"}", stdout: '2', success_count: 2, insns: %i[invokeblock leave])
     begin;
@@ -446,6 +449,7 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L449
   end
 
   def test_compile_insn_once
+    skip_on_mingw
     skip_on_mswin
     assert_compile_once('/#{true}/o =~ "true" && $~.to_a', result_inspect: '["true"]', insns: %i[once])
   end
@@ -517,11 +521,13 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L521
   end
 
   def test_compile_insn_opt_aref_with
+    skip_on_mingw
     skip_on_mswin
     assert_compile_once("{ '1' => 2 }['1']", result_inspect: '2', insns: %i[opt_aref_with])
   end
 
   def test_compile_insn_opt_aset
+    skip_on_mingw
     skip_on_mswin
     assert_compile_once("#{<<~"begin;"}\n#{<<~"end;"}", result_inspect: '5', insns: %i[opt_aset opt_aset_with])
     begin;
@@ -833,6 +839,12 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L839
     end
   end
 
+  def skip_on_mingw
+    if RUBY_PLATFORM.match?(/mingw/)
+      skip 'This test does not succeed on mingw yet.'
+    end
+  end
+
   # The shortest way to test one proc
   def assert_compile_once(script, result_inspect:, insns: [])
     if script.match?(/\A\n.+\n\z/m)

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]