mame	2018-01-09 22:04:24 +0900 (Tue, 09 Jan 2018)

  New Revision: 61727

  https://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=revision&revision=61727

  Log:
    parse.y: insane syntax too (class definition in cond)
    
    This change partially reverts r61724 and take another approach:
    exploiting struct local_vars to backup the cond_stack state.

  Modified files:
    trunk/parse.y
    trunk/test/ruby/test_syntax.rb
Index: test/ruby/test_syntax.rb
===================================================================
--- test/ruby/test_syntax.rb	(revision 61726)
+++ test/ruby/test_syntax.rb	(revision 61727)
@@ -1186,6 +1186,11 @@ eom https://github.com/ruby/ruby/blob/trunk/test/ruby/test_syntax.rb#L1186
     assert_valid_syntax('while def foo a = tap do end; end; break; end')
   end
 
+  def test_classdef_in_cond
+    assert_valid_syntax('while class Foo; tap do end; end; break; end')
+    assert_valid_syntax('while class Foo a = tap do end; end; break; end')
+  end
+
   private
 
   def not_label(x) @result = x; @not_label ||= nil end
Index: parse.y
===================================================================
--- parse.y	(revision 61726)
+++ parse.y	(revision 61727)
@@ -152,7 +152,7 @@ struct local_vars { https://github.com/ruby/ruby/blob/trunk/parse.y#L152
     struct vtable *past;
 # endif
     struct local_vars *prev;
-    stack_type cmdargs;
+    stack_type cmdargs, cond; /* XXX: backup for cmdargs_stack and cond_stack.  Because this is not a part of local variables, refactoring is needed. */
 };
 
 #define DVARS_INHERIT ((void*)1)
@@ -2900,31 +2900,22 @@ primary		: literal https://github.com/ruby/ruby/blob/trunk/parse.y#L2900
 			$<num>$ = in_def;
 			in_def = 1;
 		    }
-		    {
-			$<val>1 = cond_stack;
-			$<val>$ = cmdarg_stack;
-			COND_SET(0);
-			CMDARG_SET(0);
-		    }
 		  f_arglist
 		  bodystmt
 		  k_end
 		    {
 		    /*%%%*/
-			NODE *body = remove_begin($7);
+			NODE *body = remove_begin($6);
 			reduce_nodes(&body);
-			$$ = NEW_DEFN($2, $6, body, &@$);
-			nd_set_line($$->nd_defn, @8.end_pos.lineno);
+			$$ = NEW_DEFN($2, $5, body, &@$);
+			nd_set_line($$->nd_defn, @7.end_pos.lineno);
 			set_line_body(body, @1.beg_pos.lineno);
 		    /*%
-			$$ = dispatch3(def, $2, $6, $7);
+			$$ = dispatch3(def, $2, $5, $6);
 		    %*/
 			local_pop();
 			in_def = $<num>4 & 1;
 			current_arg = $<id>3;
-
-			COND_SET($<val>1);
-			CMDARG_SET($<val>5);
 		    }
 		| k_def singleton dot_or_colon {SET_LEX_STATE(EXPR_FNAME);} fname
 		    {
@@ -2935,31 +2926,22 @@ primary		: literal https://github.com/ruby/ruby/blob/trunk/parse.y#L2926
 			$<id>$ = current_arg;
 			current_arg = 0;
 		    }
-		    {
-			$<val>1 = cond_stack;
-			$<val>$ = cmdarg_stack;
-			COND_SET(0);
-			CMDARG_SET(0);
-		    }
 		  f_arglist
 		  bodystmt
 		  k_end
 		    {
 		    /*%%%*/
-			NODE *body = remove_begin($9);
+			NODE *body = remove_begin($8);
 			reduce_nodes(&body);
-			$$ = NEW_DEFS($2, $5, $8, body, &@$);
-			nd_set_line($$->nd_defn, @10.end_pos.lineno);
+			$$ = NEW_DEFS($2, $5, $7, body, &@$);
+			nd_set_line($$->nd_defn, @9.end_pos.lineno);
 			set_line_body(body, @1.beg_pos.lineno);
 		    /*%
-			$$ = dispatch5(defs, $2, $<val>3, $5, $8, $9);
+			$$ = dispatch5(defs, $2, $<val>3, $5, $7, $8);
 		    %*/
 			local_pop();
 			in_def = $<num>4 & 1;
 			current_arg = $<id>6;
-
-			COND_SET($<val>1);
-			CMDARG_SET($<val>7);
 		    }
 		| keyword_break
 		    {
@@ -10675,6 +10657,8 @@ local_push_gen(struct parser_params *par https://github.com/ruby/ruby/blob/trunk/parse.y#L10657
 # endif
     local->cmdargs = cmdarg_stack;
     CMDARG_SET(0);
+    local->cond = cond_stack;
+    COND_SET(0);
     lvtbl = local;
 }
 
@@ -10696,6 +10680,7 @@ local_pop_gen(struct parser_params *pars https://github.com/ruby/ruby/blob/trunk/parse.y#L10680
     vtable_free(lvtbl->args);
     vtable_free(lvtbl->vars);
     CMDARG_SET(lvtbl->cmdargs);
+    COND_SET(lvtbl->cond);
     xfree(lvtbl);
     lvtbl = local;
 }

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/