ko1	2011-07-01 07:29:34 +0900 (Fri, 01 Jul 2011)

  New Revision: 32345

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=32345

  Log:
    * thread.c (rb_threadptr_check_signal): only wake up main thread.
    * thread.c (rb_threadptr_execute_interrupts_common): check signal
      deliverly if it is main thread.
      fixes [ruby-dev:44005] [Ruby 1.9 - Bug #4950]
    * bootstraptest/test_fork.rb: add a test for above.
    * signal.c (rb_get_next_signal): skip if signal_buff is empty.
      (check signal_buff.size first)
    * vm_core.h: remove unused variable rb_thread_t::exec_signal.
    * thread.c (rb_thread_check_trap_pending): check
      rb_signal_buff_size() because rb_thread_t::exec_signal
      is no longer available.

  Modified files:
    trunk/ChangeLog
    trunk/bootstraptest/test_fork.rb
    trunk/signal.c
    trunk/thread.c
    trunk/vm_core.h

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 32344)
+++ ChangeLog	(revision 32345)
@@ -1,3 +1,22 @@
+Fri Jul  1 06:41:36 2011  Koichi Sasada  <ko1@a...>
+
+	* thread.c (rb_threadptr_check_signal): only wake up main thread.
+
+	* thread.c (rb_threadptr_execute_interrupts_common): check signal
+	  deliverly if it is main thread.
+	  fixes [ruby-dev:44005] [Ruby 1.9 - Bug #4950]
+
+	* bootstraptest/test_fork.rb: add a test for above.
+
+	* signal.c (rb_get_next_signal): skip if signal_buff is empty.
+	 (check signal_buff.size first)
+
+	* vm_core.h: remove unused variable rb_thread_t::exec_signal.
+
+	* thread.c (rb_thread_check_trap_pending): check
+	  rb_signal_buff_size() because rb_thread_t::exec_signal
+	  is no longer available.
+
 Fri Jul  1 03:28:25 2011  Yukihiro Matsumoto  <matz@r...>
 
 	* class.c (Init_class_hierarchy): should name BasicObject
Index: bootstraptest/test_fork.rb
===================================================================
--- bootstraptest/test_fork.rb	(revision 32344)
+++ bootstraptest/test_fork.rb	(revision 32345)
@@ -47,3 +47,23 @@
     :ok
   end
 }, '[ruby-core:28924]'
+
+assert_equal '[1, 2]', %q{
+  a = []
+  trap(:INT) { a.push(1) }
+  trap(:TERM) { a.push(2) }
+  pid = $$
+  begin
+    fork do
+      sleep 0.5
+      Process.kill(:INT, pid)
+      Process.kill(:TERM, pid)
+    end
+
+    sleep 1
+    a.sort
+  rescue NotImplementedError
+    [1, 2]
+  end
+}, '[ruby-dev:44005] [Ruby 1.9 - Bug #4950]'
+
Index: vm_core.h
===================================================================
--- vm_core.h	(revision 32344)
+++ vm_core.h	(revision 32345)
@@ -428,7 +428,6 @@
 
     VALUE errinfo;
     VALUE thrown_errinfo;
-    int exec_signal;
 
     rb_atomic_t interrupt_flag;
     rb_thread_lock_t interrupt_lock;
Index: thread.c
===================================================================
--- thread.c	(revision 32344)
+++ thread.c	(revision 32345)
@@ -981,7 +981,7 @@
 int
 rb_thread_check_trap_pending(void)
 {
-    return GET_THREAD()->exec_signal != 0;
+    return rb_signal_buff_size() != 0;
 }
 
 /* This function can be called in blocking region. */
@@ -1269,14 +1269,15 @@
 	enum rb_thread_status status = th->status;
 	int timer_interrupt = interrupt & 0x01;
 	int finalizer_interrupt = interrupt & 0x04;
+	int sig;
 
 	th->status = THREAD_RUNNABLE;
 
 	/* signal handling */
-	if (th->exec_signal) {
-	    int sig = th->exec_signal;
-	    th->exec_signal = 0;
-	    rb_signal_exec(th, sig);
+	if (th == th->vm->main_thread) {
+	    while ((sig = rb_get_next_signal()) != 0) {
+		rb_signal_exec(th, sig);
+	    }
 	}
 
 	/* exception from another thread */
@@ -2934,14 +2935,9 @@
 void
 rb_threadptr_check_signal(rb_thread_t *mth)
 {
-    int sig;
-
     /* mth must be main_thread */
-
-    if (!mth->exec_signal && (sig = rb_get_next_signal()) > 0) {
-	thread_debug("main_thread: %s, sig: %d\n",
-		     thread_status_name(mth->status), sig);
-	mth->exec_signal = sig;
+    if (rb_signal_buff_size() > 0) {
+	/* wakeup main thread */
 	rb_threadptr_interrupt(mth);
     }
 }
Index: signal.c
===================================================================
--- signal.c	(revision 32344)
+++ signal.c	(revision 32345)
@@ -554,16 +554,18 @@
 {
     int i, sig = 0;
 
-    for (i=1; i<RUBY_NSIG; i++) {
-	if (signal_buff.cnt[i] > 0) {
-	    rb_disable_interrupt();
-	    {
-		ATOMIC_DEC(signal_buff.cnt[i]);
-		ATOMIC_DEC(signal_buff.size);
+    if (signal_buff.size != 0) {
+	for (i=1; i<RUBY_NSIG; i++) {
+	    if (signal_buff.cnt[i] > 0) {
+		rb_disable_interrupt();
+		{
+		    ATOMIC_DEC(signal_buff.cnt[i]);
+		    ATOMIC_DEC(signal_buff.size);
+		}
+		rb_enable_interrupt();
+		sig = i;
+		break;
 	    }
-	    rb_enable_interrupt();
-	    sig = i;
-	    break;
 	}
     }
     return sig;

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/