[前][次][番号順一覧][スレッド一覧]

ruby-changes:62232

From: Utkarsh <ko1@a...>
Date: Wed, 15 Jul 2020 16:05:45 +0900 (JST)
Subject: [ruby-changes:62232] 077dcacb08 (master): [rubygems/rubygems] Use `--config .rubocop.yml` instead

https://git.ruby-lang.org/ruby.git/commit/?id=077dcacb08

From 077dcacb0892d8cd36cc45ae8869031c62502919 Mon Sep 17 00:00:00 2001
From: Utkarsh Gupta <utkarsh@d...>
Date: Sun, 21 Jun 2020 21:43:46 +0530
Subject: [rubygems/rubygems] Use `--config .rubocop.yml` instead

because rubocop configuration inheritance is
messed up and when using `--ignore-parent-exclusion`,
even though the exit status is 0, the example
still fails because of the configuration issue.

Signed-off-by: Utkarsh Gupta <utkarsh@d...>

https://github.com/rubygems/rubygems/commit/3e20b2738c

diff --git a/spec/bundler/commands/newgem_spec.rb b/spec/bundler/commands/newgem_spec.rb
index 0287fb6..4427a65 100644
--- a/spec/bundler/commands/newgem_spec.rb
+++ b/spec/bundler/commands/newgem_spec.rb
@@ -180,7 +180,7 @@ RSpec.describe "bundle gem" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/commands/newgem_spec.rb#L180
       gems = ["rake", "rubocop -v 0.80.1"]
       path = Bundler.feature_flag.default_install_uses_path? ? local_gem_path(:base => bundled_app(gem_name)) : system_gem_path
       realworld_system_gems gems, :path => path
-      bundle "exec rubocop --ignore-parent-exclusion", :dir => bundled_app(gem_name)
+      bundle "exec rubocop --config .rubocop.yml", :dir => bundled_app(gem_name)
       expect($?.exitstatus).to eq(0) if exitstatus
     end
   end
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]