[前][次][番号順一覧][スレッド一覧]

ruby-changes:62231

From: Utkarsh <ko1@a...>
Date: Wed, 15 Jul 2020 16:05:44 +0900 (JST)
Subject: [ruby-changes:62231] 215f7c3165 (master): [rubygems/rubygems] Fix linting and make Style/RedundantInterpolation happy

https://git.ruby-lang.org/ruby.git/commit/?id=215f7c3165

From 215f7c31658a649efa276e18811d69f111931f0f Mon Sep 17 00:00:00 2001
From: Utkarsh Gupta <utkarsh@d...>
Date: Sun, 21 Jun 2020 02:07:14 +0530
Subject: [rubygems/rubygems] Fix linting and make Style/RedundantInterpolation
 happy

Signed-off-by: Utkarsh Gupta <utkarsh@d...>

https://github.com/rubygems/rubygems/commit/83e330fa87

diff --git a/spec/bundler/commands/newgem_spec.rb b/spec/bundler/commands/newgem_spec.rb
index c45cc8d..b1e84c7 100644
--- a/spec/bundler/commands/newgem_spec.rb
+++ b/spec/bundler/commands/newgem_spec.rb
@@ -155,7 +155,7 @@ RSpec.describe "bundle gem" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/commands/newgem_spec.rb#L155
     it "generates a gem skeleton with rubocop" do
       gem_skeleton_assertions
       expect(bundled_app("test-gem/Rakefile")).to read_as(
-        include('# frozen_string_literal: true').
+        include("# frozen_string_literal: true").
         and(include('require "rubocop/rake_task"').
         and(include("RuboCop::RakeTask.new").
         and(match(/default:.+:rubocop/))))
@@ -176,11 +176,11 @@ RSpec.describe "bundle gem" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/commands/newgem_spec.rb#L176
     end
 
     it "run rubocop inside the generated gem with no offenses" do
-      prepare_gemspec(bundled_app("#{gem_name}", "#{gem_name}.gemspec"))
+      prepare_gemspec(bundled_app(gem_name, "#{gem_name}.gemspec"))
       gems = ["rake", "rubocop"]
-      path = Bundler.feature_flag.default_install_uses_path? ? local_gem_path(:base => bundled_app("#{gem_name}")) : system_gem_path
+      path = Bundler.feature_flag.default_install_uses_path? ? local_gem_path(:base => bundled_app(gem_name)) : system_gem_path
       realworld_system_gems gems, :path => path
-      bundle "exec rubocop --ignore-parent-exclusion", :dir => bundled_app("#{gem_name}")
+      bundle "exec rubocop --ignore-parent-exclusion", :dir => bundled_app(gem_name)
       expect($?.exitstatus).to eq(0) if exitstatus
     end
   end
-- 
cgit v0.10.2


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]