ruby-changes:9363
From: kouji <ko1@a...>
Date: Sun, 21 Dec 2008 14:49:34 +0900 (JST)
Subject: [ruby-changes:9363] Ruby:r20901 (trunk): * test/readline/test_readline_history.rb: checked encoding.
kouji 2008-12-21 14:49:18 +0900 (Sun, 21 Dec 2008) New Revision: 20901 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=20901 Log: * test/readline/test_readline_history.rb: checked encoding. Modified files: trunk/ChangeLog trunk/test/readline/test_readline_history.rb Index: ChangeLog =================================================================== --- ChangeLog (revision 20900) +++ ChangeLog (revision 20901) @@ -1,3 +1,7 @@ +Sun Dec 21 14:48:51 2008 TAKAO Kouji <kouji@t...> + + * test/readline/test_readline_history.rb: checked encoding. + Sun Dec 21 14:45:58 2008 Nobuyoshi Nakada <nobu@r...> * lib/optparse.rb (parse_in_order): splat values to be passed. Index: test/readline/test_readline_history.rb =================================================================== --- test/readline/test_readline_history.rb (revision 20900) +++ test/readline/test_readline_history.rb (revision 20901) @@ -75,13 +75,14 @@ end def test_to_s - assert_equal("HISTORY", HISTORY.to_s) + expected = "HISTORY" + assert_equal(expected, HISTORY.to_s) end def test_get lines = push_history(5) lines.each_with_index do |s, i| - assert_equal(s, HISTORY[i]) + assert_encoded_string_equal(s, HISTORY[i]) end end @@ -115,8 +116,9 @@ lines = push_history(5) 5.times do |i| expected = "set: #{i}" - HISTORY[i] = expected - assert_equal(expected, HISTORY[i]) + s = (HISTORY[i] = expected) + assert_encoded_string_equal(expected, HISTORY[i]) + assert_encoded_string_equal(expected, s) end rescue NotImplementedError end @@ -146,16 +148,18 @@ def test_push 5.times do |i| - assert_equal(HISTORY, HISTORY.push(i.to_s)) - assert_equal(i.to_s, HISTORY[i]) + s = i.to_s + assert_equal(HISTORY, HISTORY.push(s)) + assert_encoded_string_equal(s, HISTORY[i]) end assert_equal(5, HISTORY.length) end def test_push__operator 5.times do |i| - assert_equal(HISTORY, HISTORY << i.to_s) - assert_equal(i.to_s, HISTORY[i]) + s = i.to_s + assert_equal(HISTORY, HISTORY << s) + assert_encoded_string_equal(s, HISTORY[i]) end assert_equal(5, HISTORY.length) end @@ -163,13 +167,13 @@ def test_push__plural assert_equal(HISTORY, HISTORY.push("0", "1", "2", "3", "4")) (0..4).each do |i| - assert_equal(i.to_s, HISTORY[i]) + assert_encoded_string_equal(i.to_s, HISTORY[i]) end assert_equal(5, HISTORY.length) assert_equal(HISTORY, HISTORY.push("5", "6", "7", "8", "9")) (5..9).each do |i| - assert_equal(i.to_s, HISTORY[i]) + assert_encoded_string_equal(i.to_s, HISTORY[i]) end assert_equal(10, HISTORY.length) end @@ -180,7 +184,7 @@ lines = push_history(5) (1..5).each do |i| - assert_equal(lines[-i], HISTORY.pop) + assert_encoded_string_equal(lines[-i], HISTORY.pop) assert_equal(lines.length - i, HISTORY.length) end @@ -195,7 +199,7 @@ lines = push_history(5) (0..4).each do |i| - assert_equal(lines[i], HISTORY.shift) + assert_encoded_string_equal(lines[i], HISTORY.shift) assert_equal(lines.length - (i + 1), HISTORY.length) end @@ -212,8 +216,8 @@ lines = push_history(5) i = 0 e = HISTORY.each do |s| - assert_equal(HISTORY[i], s) - assert_equal(lines[i], s) + assert_encoded_string_equal(HISTORY[i], s) + assert_encoded_string_equal(lines[i], s) i += 1 end assert_equal(HISTORY, e) @@ -248,22 +252,22 @@ begin lines = push_history(5) (0..4).each do |i| - assert_equal(lines[i], HISTORY.delete_at(0)) + assert_encoded_string_equal(lines[i], HISTORY.delete_at(0)) end assert(HISTORY.empty?) lines = push_history(5) (1..5).each do |i| - assert_equal(lines[lines.length - i], HISTORY.delete_at(-1)) + assert_encoded_string_equal(lines[lines.length - i], HISTORY.delete_at(-1)) end assert(HISTORY.empty?) lines = push_history(5) - assert_equal(lines[0], HISTORY.delete_at(0)) - assert_equal(lines[4], HISTORY.delete_at(3)) - assert_equal(lines[1], HISTORY.delete_at(0)) - assert_equal(lines[3], HISTORY.delete_at(1)) - assert_equal(lines[2], HISTORY.delete_at(0)) + assert_encoded_string_equal(lines[0], HISTORY.delete_at(0)) + assert_encoded_string_equal(lines[4], HISTORY.delete_at(3)) + assert_encoded_string_equal(lines[1], HISTORY.delete_at(0)) + assert_encoded_string_equal(lines[3], HISTORY.delete_at(1)) + assert_encoded_string_equal(lines[2], HISTORY.delete_at(0)) assert(HISTORY.empty?) rescue NotImplementedError end @@ -305,6 +309,11 @@ HISTORY.push(*lines) return lines end + + def assert_encoded_string_equal(expected, actual) + assert_equal(expected, actual) + assert_equal(expected.encoding, actual.encoding) + end end if defined?(::Readline) && defined?(::Readline::HISTORY) && ( begin -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/