wanabe	2008-10-31 12:49:29 +0900 (Fri, 31 Oct 2008)

  New Revision: 20071

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=20071

  Log:
    * array.c (rb_ary_decrement_share): fix to work recycling
      shared-array without the following.  [ruby-dev:36991]
    * array.c (ary_make_substitution): don't recycle substitution array.

  Modified files:
    trunk/ChangeLog
    trunk/array.c

Index: array.c
===================================================================
--- array.c	(revision 20070)
+++ array.c	(revision 20071)
@@ -177,7 +177,7 @@
 {
     if (shared) {
 	int num = ARY_SHARED_NUM(shared) - 1;
-	if (num == 0 && RBASIC(shared)->klass) {
+	if (num == 0) {
 	    rb_ary_free(shared);
 	    rb_gc_force_recycle(shared);
 	}
@@ -202,13 +202,19 @@
     }
 }
 
-static void
-rb_ary_set_shared(VALUE ary, VALUE shared)
-{
+static VALUE
+rb_ary_increment_share(VALUE shared) {
     int num = ARY_SHARED_NUM(shared);
     if (num >= 0) {
 	ARY_SET_SHARED_NUM(shared, num + 1);
     }
+    return shared;
+}
+
+static void
+rb_ary_set_shared(VALUE ary, VALUE shared)
+{
+    rb_ary_increment_share(shared);
     FL_SET_SHARED(ary);
     ARY_SET_SHARED(ary, shared);
 }
@@ -396,7 +402,7 @@
         return subst;
     }
     else {
-        return ary_make_shared(ary);
+        return rb_ary_increment_share(ary_make_shared(ary));
     }
 }
 
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 20070)
+++ ChangeLog	(revision 20071)
@@ -1,3 +1,10 @@
+Fri Oct 31 12:42:45 2008  wanabe  <s.wanabe@g...>
+
+	* array.c (rb_ary_decrement_share): fix to work recycling
+	  shared-array without the following.  [ruby-dev:36991]
+
+	* array.c (ary_make_substitution): don't recycle substitution array.
+
 Fri Oct 31 12:27:52 2008  Yuki Sonoda (Yugui)  <yugui@y...>
 
 	* spec/default.mspec: supports that the build directory != srcdir.

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/