ruby-changes:8113
From: ryan <ko1@a...>
Date: Tue, 30 Sep 2008 15:57:52 +0900 (JST)
Subject: [ruby-changes:8113] Ruby:r19639 (trunk): Updated miniunit to 4257. This cleans all my tests when run in isolation. I still have failures when run with everything else
ryan 2008-09-30 15:57:34 +0900 (Tue, 30 Sep 2008) New Revision: 19639 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=19639 Log: Updated miniunit to 4257. This cleans all my tests when run in isolation. I still have failures when run with everything else Modified files: trunk/ChangeLog trunk/lib/mini/mock.rb trunk/lib/mini/test.rb trunk/test/mini/test_mini_test.rb Index: ChangeLog =================================================================== --- ChangeLog (revision 19638) +++ ChangeLog (revision 19639) @@ -5,8 +5,8 @@ Tue Sep 30 13:04:11 2008 Ryan Davis <ryand-ruby@z...> - * lib/mini/test.rb: Updated to 1.3.0 r4256. - * test/mini/*: added from r4255. + * lib/mini/test.rb: Updated to 1.3.0 r4257. + * test/mini/*: added from r4257. Tue Sep 30 07:46:07 2008 Eric Hodel <drbrain@s...> Index: lib/mini/test.rb =================================================================== --- lib/mini/test.rb (revision 19638) +++ lib/mini/test.rb (revision 19639) @@ -14,13 +14,15 @@ class Assertion < Exception; end class Skip < Assertion; end - file = if __FILE__ =~ /^[^\.]/ then # OMG ruby 1.9 is so lame (rubinius too) + file = if RUBY_VERSION =~ /^1\.9/ then # bt's expanded, but __FILE__ isn't :( + File.expand_path __FILE__ + elsif __FILE__ =~ /^[^\.]/ then # assume both relative require 'pathname' - pwd = Pathname.new(Dir.pwd) - pn = Pathname.new(File.expand_path(__FILE__)) + pwd = Pathname.new Dir.pwd + pn = Pathname.new File.expand_path(__FILE__) pn = File.join(".", pn.relative_path_from(pwd)) unless pn.relative? pn.to_s - else + else # assume both are expanded __FILE__ end @@ -36,10 +38,8 @@ new_bt << line end - new_bt = bt.reject { |line| line.rindex(MINI_DIR, 0) } if - new_bt.empty? + new_bt = bt.reject { |line| line.rindex(MINI_DIR, 0) } if new_bt.empty? new_bt = bt.dup if new_bt.empty? - new_bt end Index: lib/mini/mock.rb =================================================================== --- lib/mini/mock.rb (revision 19638) +++ lib/mini/mock.rb (revision 19639) @@ -17,9 +17,9 @@ def expect(name, retval, args=[]) n, r, a = name, retval, args # for the closure below @expected_calls[name] = { :retval => retval, :args => args } - self.class.__send__(:define_method, name) { |*a| - raise ArgumentError unless @expected_calls[n][:args].size == a.size - @actual_calls[n] << { :retval => r, :args => a } + self.class.__send__(:define_method, name) { |*x| + raise ArgumentError unless @expected_calls[n][:args].size == x.size + @actual_calls[n] << { :retval => r, :args => x } retval } self Index: test/mini/test_mini_test.rb =================================================================== --- test/mini/test_mini_test.rb (revision 19638) +++ test/mini/test_mini_test.rb (revision 19639) @@ -9,11 +9,6 @@ Mini::Test.autorun -class Mini::Test - attr_accessor :test_count - attr_accessor :assertion_count -end - class TestMiniTest < Mini::Test::TestCase def setup @@ -47,13 +42,25 @@ BT_MIDDLE + ["./lib/mini/test.rb:29", "test/test_autotest.rb:422"]) + bt = util_expand_bt bt + ex = ["lib/autotest.rb:571:in `add_exception'", "test/test_autotest.rb:62:in `test_add_exception'"] + ex = util_expand_bt ex + fu = Mini::filter_backtrace(bt) assert_equal ex, fu end + def util_expand_bt bt + if RUBY_VERSION =~ /^1\.9/ then + bt.map { |f| (f =~ /^\./) ? File.expand_path(f) : f } + else + bt + end + end + def test_filter_backtrace_all_unit bt = (["./lib/mini/test.rb:165:in `__send__'"] + BT_MIDDLE + @@ -68,6 +75,9 @@ BT_MIDDLE + ["./lib/mini/test.rb:29", "-e:1"]) + + bt = util_expand_bt bt + ex = ["-e:1"] fu = Mini::filter_backtrace(bt) assert_equal ex, fu -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/