nobu	2008-08-31 13:48:02 +0900 (Sun, 31 Aug 2008)

  New Revision: 18977

  http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=18977

  Log:
    * ext/coverage/coverage.c (rb_mCoverage): removed unneeded static variable.
    
    * ext/socket/socket.c (unix_recv_io): ditto.
    
    * ext/socket/socket.c (mConst): ditto.

  Modified files:
    trunk/ChangeLog
    trunk/ext/coverage/coverage.c
    trunk/ext/socket/socket.c

Index: ChangeLog
===================================================================
--- ChangeLog	(revision 18976)
+++ ChangeLog	(revision 18977)
@@ -1,3 +1,11 @@
+Sun Aug 31 13:47:59 2008  Nobuyoshi Nakada  <nobu@r...>
+
+	* ext/coverage/coverage.c (rb_mCoverage): removed unneeded static variable.
+
+	* ext/socket/socket.c (unix_recv_io): ditto.
+
+	* ext/socket/socket.c (mConst): ditto.
+
 Sun Aug 31 13:45:41 2008  Nobuyoshi Nakada  <nobu@r...>
 
 	* ext/openssl/ossl_ocsp.c (ossl_ocspres_initialize): fix for
Index: ext/coverage/coverage.c
===================================================================
--- ext/coverage/coverage.c	(revision 18976)
+++ ext/coverage/coverage.c	(revision 18977)
@@ -10,8 +10,6 @@
 
 #include "ruby.h"
 
-static VALUE rb_mCoverage;
-
 extern VALUE rb_get_coverages(void);
 extern void rb_set_coverages(VALUE);
 extern void rb_reset_coverages(void);
@@ -97,7 +95,7 @@
 void
 Init_coverage(void)
 {
-    rb_mCoverage = rb_define_module("Coverage");
+    VALUE rb_mCoverage = rb_define_module("Coverage");
     rb_define_module_function(rb_mCoverage, "start", rb_coverage_start, 0);
     rb_define_module_function(rb_mCoverage, "result", rb_coverage_result, 0);
 }
Index: ext/socket/socket.c
===================================================================
--- ext/socket/socket.c	(revision 18976)
+++ ext/socket/socket.c	(revision 18977)
@@ -2149,11 +2149,10 @@
     if (klass == Qnil)
 	return INT2FIX(fd);
     else {
-	static ID for_fd = 0;
+	ID for_fd;
 	int ff_argc;
 	VALUE ff_argv[2];
-	if (!for_fd)
-	    for_fd = rb_intern("for_fd");
+	CONST_ID(for_fd, "for_fd");
 	ff_argc = mode == Qnil ? 1 : 2;
 	ff_argv[0] = INT2FIX(fd);
 	ff_argv[1] = mode;
@@ -3561,14 +3560,13 @@
 }
 #endif
 
-static VALUE mConst;
-
 static void
-sock_define_const(const char *name, int value)
+sock_define_const(const char *name, int value, VALUE mConst)
 {
     rb_define_const(rb_cSocket, name, INT2FIX(value));
     rb_define_const(mConst, name, INT2FIX(value));
 }
+#define sock_define_const(name, value) sock_define_const(name, value, mConst)
 
 /*
  * Class +Socket+ provides access to the underlying operating system
@@ -3598,6 +3596,8 @@
 void
 Init_socket()
 {
+    VALUE mConst;
+
     rb_eSocket = rb_define_class("SocketError", rb_eStandardError);
 
     rb_cBasicSocket = rb_define_class("BasicSocket", rb_cIO);

--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/