[前][次][番号順一覧][スレッド一覧]

ruby-changes:74350

From: Peter <ko1@a...>
Date: Fri, 4 Nov 2022 22:04:26 +0900 (JST)
Subject: [ruby-changes:74350] 93f364d65e (master): Use RTEST to to check return value

https://git.ruby-lang.org/ruby.git/commit/?id=93f364d65e

From 93f364d65e25187ce3c1dd5172a00264804e9380 Mon Sep 17 00:00:00 2001
From: Peter Zhu <peter@p...>
Date: Fri, 4 Nov 2022 09:02:58 -0400
Subject: Use RTEST to to check return value

rb_obj_is_kind_of returns a Ruby Qtrue or Qfalse. We should use RTEST
rather than assuming that Qfalse is 0.
---
 proc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/proc.c b/proc.c
index 1f047cd04f..a25786c015 100644
--- a/proc.c
+++ b/proc.c
@@ -2571,7 +2571,7 @@ convert_umethod_to_method_components(const struct METHOD *data, VALUE recv, VALU https://github.com/ruby/ruby/blob/trunk/proc.c#L2571
         VALUE refined_class = rb_refinement_module_get_refined_class(methclass);
         if (!NIL_P(refined_class)) methclass = refined_class;
     }
-    if (!RB_TYPE_P(methclass, T_MODULE) && !rb_obj_is_kind_of(recv, methclass)) {
+    if (!RB_TYPE_P(methclass, T_MODULE) && !RTEST(rb_obj_is_kind_of(recv, methclass))) {
         if (FL_TEST(methclass, FL_SINGLETON)) {
             rb_raise(rb_eTypeError,
                      "singleton method called for a different object");
-- 
cgit v1.2.3


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]