ruby-changes:74218
From: Nobuyoshi <ko1@a...>
Date: Mon, 24 Oct 2022 09:37:22 +0900 (JST)
Subject: [ruby-changes:74218] 174ddc79c5 (master): Skip `File.atime`/`File.mtime` tests randomly failing on Travis
https://git.ruby-lang.org/ruby.git/commit/?id=174ddc79c5 From 174ddc79c53ffe2efbccfe8737e7b8d50fe79050 Mon Sep 17 00:00:00 2001 From: Nobuyoshi Nakada <nobu@r...> Date: Mon, 24 Oct 2022 00:33:51 +0900 Subject: Skip `File.atime`/`File.mtime` tests randomly failing on Travis Not only powerpc64le, also s390x and arm32 seem failing too. These failures are probably caused by filesystem settings on Travis, but unrelated to CPUs. --- spec/ruby/core/file/atime_spec.rb | 2 +- spec/ruby/core/file/mtime_spec.rb | 18 ++++++++++-------- 2 files changed, 11 insertions(+), 9 deletions(-) diff --git a/spec/ruby/core/file/atime_spec.rb b/spec/ruby/core/file/atime_spec.rb index 3dc00fea21..1b47576e6b 100644 --- a/spec/ruby/core/file/atime_spec.rb +++ b/spec/ruby/core/file/atime_spec.rb @@ -16,7 +16,7 @@ describe "File.atime" do https://github.com/ruby/ruby/blob/trunk/spec/ruby/core/file/atime_spec.rb#L16 end platform_is :linux, :windows do - platform_is_not :"powerpc64le-linux" do # https://bugs.ruby-lang.org/issues/17926 + unless ENV.key?('TRAVIS') # https://bugs.ruby-lang.org/issues/17926 ## NOTE also that some Linux systems disable atime (e.g. via mount params) for better filesystem speed. it "returns the last access time for the named file with microseconds" do supports_subseconds = Integer(`stat -c%x '#{__FILE__}'`[/\.(\d{1,6})/, 1], 10) diff --git a/spec/ruby/core/file/mtime_spec.rb b/spec/ruby/core/file/mtime_spec.rb index f89ee5d7f9..5304bbf057 100644 --- a/spec/ruby/core/file/mtime_spec.rb +++ b/spec/ruby/core/file/mtime_spec.rb @@ -16,14 +16,16 @@ describe "File.mtime" do https://github.com/ruby/ruby/blob/trunk/spec/ruby/core/file/mtime_spec.rb#L16 end platform_is :linux, :windows do - it "returns the modification Time of the file with microseconds" do - supports_subseconds = Integer(`stat -c%y '#{__FILE__}'`[/\.(\d{1,6})/, 1], 10) - if supports_subseconds != 0 - expected_time = Time.at(Time.now.to_i + 0.123456) - File.utime 0, expected_time, @filename - File.mtime(@filename).usec.should == expected_time.usec - else - File.mtime(__FILE__).usec.should == 0 + unless ENV.key?('TRAVIS') # https://bugs.ruby-lang.org/issues/17926 + it "returns the modification Time of the file with microseconds" do + supports_subseconds = Integer(`stat -c%y '#{__FILE__}'`[/\.(\d{1,6})/, 1], 10) + if supports_subseconds != 0 + expected_time = Time.at(Time.now.to_i + 0.123456) + File.utime 0, expected_time, @filename + File.mtime(@filename).usec.should == expected_time.usec + else + File.mtime(__FILE__).usec.should == 0 + end end end end -- cgit v1.2.3 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/