[前][次][番号順一覧][スレッド一覧]

ruby-changes:73855

From: Gannon <ko1@a...>
Date: Wed, 5 Oct 2022 17:14:50 +0900 (JST)
Subject: [ruby-changes:73855] 19e4a4c624 (master): [ruby/irb] Rename IDB::ReidlineInputMethod to IRB::RelineInputMethod

https://git.ruby-lang.org/ruby.git/commit/?id=19e4a4c624

From 19e4a4c624c0872796e3fcde4923b670011e0b59 Mon Sep 17 00:00:00 2001
From: Gannon McGibbon <gannon.mcgibbon@g...>
Date: Tue, 4 Oct 2022 15:28:45 -0500
Subject: [ruby/irb] Rename IDB::ReidlineInputMethod to IRB::RelineInputMethod

Deprecates IDB::ReidlineInputMethod and USE_REIDLINE in favor of
IRB::RelineInputMethod and USE_RELINE. The Input method uses Reline to
read input from the console, so it can be named directly after the
Reline library like other inputs methods are (Readline, Stdio, etc.).

https://github.com/ruby/irb/commit/5bcade7130
---
 lib/irb/context.rb      | 27 ++++++++++++++++-----------
 lib/irb/input-method.rb | 11 ++++++++++-
 2 files changed, 26 insertions(+), 12 deletions(-)

diff --git a/lib/irb/context.rb b/lib/irb/context.rb
index a3b7dda8cd..b4c687ca40 100644
--- a/lib/irb/context.rb
+++ b/lib/irb/context.rb
@@ -22,7 +22,7 @@ module IRB https://github.com/ruby/ruby/blob/trunk/lib/irb/context.rb#L22
     #
     # The optional +input_method+ argument:
     #
-    # +nil+::     uses stdin or Reidline or Readline
+    # +nil+::     uses stdin or Reline or Readline
     # +String+::  uses a File
     # +other+::   uses this as InputMethod
     def initialize(irb, workspace = nil, input_method = nil)
@@ -48,8 +48,13 @@ module IRB https://github.com/ruby/ruby/blob/trunk/lib/irb/context.rb#L48
       end
       if IRB.conf.has_key?(:USE_MULTILINE)
         @use_multiline = IRB.conf[:USE_MULTILINE]
-      elsif IRB.conf.has_key?(:USE_REIDLINE) # backward compatibility
-        @use_multiline = IRB.conf[:USE_REIDLINE]
+      elsif IRB.conf.has_key?(:USE_RELINE) # backward compatibility
+        @use_multiline = IRB.conf[:USE_RELINE]
+      elsif IRB.conf.has_key?(:USE_REIDLINE)
+        warn <<~MSG.strip
+          USE_REIDLINE is deprecated, please use USE_RELINE instead.
+        MSG
+        @use_multiline = IRB.conf[:USE_RELINE]
       else
         @use_multiline = nil
       end
@@ -83,14 +88,14 @@ module IRB https://github.com/ruby/ruby/blob/trunk/lib/irb/context.rb#L88
         when nil
           if STDIN.tty? && IRB.conf[:PROMPT_MODE] != :INF_RUBY && !use_singleline?
             # Both of multiline mode and singleline mode aren't specified.
-            @io = ReidlineInputMethod.new
+            @io = RelineInputMethod.new
           else
             @io = nil
           end
         when false
           @io = nil
         when true
-          @io = ReidlineInputMethod.new
+          @io = RelineInputMethod.new
         end
         unless @io
           case use_singleline?
@@ -160,7 +165,7 @@ module IRB https://github.com/ruby/ruby/blob/trunk/lib/irb/context.rb#L165
     # The current input method.
     #
     # Can be either StdioInputMethod, ReadlineInputMethod,
-    # ReidlineInputMethod, FileInputMethod or other specified when the
+    # RelineInputMethod, FileInputMethod or other specified when the
     # context is created. See ::new for more # information on +input_method+.
     attr_accessor :io
 
@@ -326,9 +331,9 @@ module IRB https://github.com/ruby/ruby/blob/trunk/lib/irb/context.rb#L331
     # Alias for #use_singleline
     alias use_singleline? use_singleline
     # backward compatibility
-    alias use_reidline use_multiline
+    alias use_reline use_multiline
     # backward compatibility
-    alias use_reidline? use_multiline
+    alias use_reline? use_multiline
     # backward compatibility
     alias use_readline use_singleline
     # backward compatibility
@@ -346,7 +351,7 @@ module IRB https://github.com/ruby/ruby/blob/trunk/lib/irb/context.rb#L351
     # Returns whether messages are displayed or not.
     def verbose?
       if @verbose.nil?
-        if @io.kind_of?(ReidlineInputMethod)
+        if @io.kind_of?(RelineInputMethod)
           false
         elsif defined?(ReadlineInputMethod) && @io.kind_of?(ReadlineInputMethod)
           false
@@ -361,11 +366,11 @@ module IRB https://github.com/ruby/ruby/blob/trunk/lib/irb/context.rb#L366
     end
 
     # Whether #verbose? is +true+, and +input_method+ is either
-    # StdioInputMethod or ReidlineInputMethod or ReadlineInputMethod, see #io
+    # StdioInputMethod or RelineInputMethod or ReadlineInputMethod, see #io
     # for more information.
     def prompting?
       verbose? || (STDIN.tty? && @io.kind_of?(StdioInputMethod) ||
-                   @io.kind_of?(ReidlineInputMethod) ||
+                   @io.kind_of?(RelineInputMethod) ||
                    (defined?(ReadlineInputMethod) && @io.kind_of?(ReadlineInputMethod)))
     end
 
diff --git a/lib/irb/input-method.rb b/lib/irb/input-method.rb
index eec2daa549..aa5cb5adb9 100644
--- a/lib/irb/input-method.rb
+++ b/lib/irb/input-method.rb
@@ -261,7 +261,7 @@ module IRB https://github.com/ruby/ruby/blob/trunk/lib/irb/input-method.rb#L261
     end
   end
 
-  class ReidlineInputMethod < InputMethod
+  class RelineInputMethod < InputMethod
     include Reline
 
     # Creates a new input method object using Reline
@@ -470,4 +470,13 @@ module IRB https://github.com/ruby/ruby/blob/trunk/lib/irb/input-method.rb#L470
       str
     end
   end
+
+  class ReidlineInputMethod < RelineInputMethod
+    def initialize
+      warn <<~MSG.strip
+        IRB::ReidlineInputMethod is deprecated, please use IRB::RelineInputMethod instead.
+      MSG
+      super
+    end
+  end
 end
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]