[前][次][番号順一覧][スレッド一覧]

ruby-changes:73790

From: Jenny <ko1@a...>
Date: Thu, 29 Sep 2022 17:56:52 +0900 (JST)
Subject: [ruby-changes:73790] 28840d74c2 (master): [rubygems/rubygems] Refine error message to check the push URL instead of just the host

https://git.ruby-lang.org/ruby.git/commit/?id=28840d74c2

From 28840d74c26189f4e730b906c2383e32ea6165fe Mon Sep 17 00:00:00 2001
From: Jenny Shen <jenny.shen@s...>
Date: Mon, 19 Sep 2022 09:43:17 -0400
Subject: [rubygems/rubygems] Refine error message to check the push URL
 instead of just the host

https://github.com/rubygems/rubygems/commit/46990f3292
---
 lib/rubygems/gemcutter_utilities.rb               | 2 +-
 test/rubygems/test_gem_commands_owner_command.rb  | 8 ++++----
 test/rubygems/test_gem_commands_push_command.rb   | 2 +-
 test/rubygems/test_gem_commands_signin_command.rb | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/lib/rubygems/gemcutter_utilities.rb b/lib/rubygems/gemcutter_utilities.rb
index fb7b9149ba..3477422b79 100644
--- a/lib/rubygems/gemcutter_utilities.rb
+++ b/lib/rubygems/gemcutter_utilities.rb
@@ -213,7 +213,7 @@ module Gem::GemcutterUtilities https://github.com/ruby/ruby/blob/trunk/lib/rubygems/gemcutter_utilities.rb#L213
         say clean_text(response.body)
       end
     when Net::HTTPPermanentRedirect, Net::HTTPRedirection then
-      message = "The request has redirected permanently to #{response['location']}. Please check your defined push host."
+      message = "The request has redirected permanently to #{response['location']}. Please check your defined push host URL."
       message = "#{error_prefix}: #{message}" if error_prefix
 
       say clean_text(message)
diff --git a/test/rubygems/test_gem_commands_owner_command.rb b/test/rubygems/test_gem_commands_owner_command.rb
index e415f4bd37..32bfbb7a66 100644
--- a/test/rubygems/test_gem_commands_owner_command.rb
+++ b/test/rubygems/test_gem_commands_owner_command.rb
@@ -137,7 +137,7 @@ EOF https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_commands_owner_command.rb#L137
       end
     end
 
-    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host."
+    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host URL."
     assert_match response, @stub_ui.output
   end
 
@@ -198,7 +198,7 @@ EOF https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_commands_owner_command.rb#L198
       @cmd.add_owners("freewill", ["user-new1@e..."])
     end
 
-    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host."
+    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host URL."
     assert_match response, @stub_ui.output
   end
 
@@ -276,7 +276,7 @@ EOF https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_commands_owner_command.rb#L276
       @cmd.remove_owners("freewill", ["user-remove1@e..."])
     end
 
-    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host."
+    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host URL."
     assert_match response, @stub_ui.output
 
     path = "/api/v1/gems/freewill/owners"
@@ -293,7 +293,7 @@ EOF https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_commands_owner_command.rb#L293
       @cmd.add_owners("freewill", ["user-new1@e..."])
     end
 
-    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host."
+    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host URL."
     assert_match response, @stub_ui.output
   end
 
diff --git a/test/rubygems/test_gem_commands_push_command.rb b/test/rubygems/test_gem_commands_push_command.rb
index 5ce6bd161b..ef7730558d 100644
--- a/test/rubygems/test_gem_commands_push_command.rb
+++ b/test/rubygems/test_gem_commands_push_command.rb
@@ -342,7 +342,7 @@ class TestGemCommandsPushCommand < Gem::TestCase https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_commands_push_command.rb#L342
       end
     end
 
-    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host."
+    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host URL."
     assert_match response, @ui.output
   end
 
diff --git a/test/rubygems/test_gem_commands_signin_command.rb b/test/rubygems/test_gem_commands_signin_command.rb
index 47b45e9be8..281e4f9eac 100644
--- a/test/rubygems/test_gem_commands_signin_command.rb
+++ b/test/rubygems/test_gem_commands_signin_command.rb
@@ -92,7 +92,7 @@ class TestGemCommandsSigninCommand < Gem::TestCase https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem_commands_signin_command.rb#L92
       end
     end
 
-    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host."
+    response = "The request has redirected permanently to #{redirected_uri}. Please check your defined push host URL."
     assert_match response, ui.output
   end
 
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]