ruby-changes:73776
From: David <ko1@a...>
Date: Thu, 29 Sep 2022 03:42:09 +0900 (JST)
Subject: [ruby-changes:73776] 1e5597532a (master): [rubygems/rubygems] Cleaup unnecessary code
https://git.ruby-lang.org/ruby.git/commit/?id=1e5597532a From 1e5597532ac72ae324550c7cf58f94017f0c8072 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...> Date: Sat, 4 Dec 2021 12:49:00 +0100 Subject: [rubygems/rubygems] Cleaup unnecessary code https://github.com/rubygems/rubygems/commit/2e05dadbc5 --- test/rubygems/rubygems_plugin.rb | 9 --------- test/rubygems/test_gem.rb | 11 ----------- 2 files changed, 20 deletions(-) diff --git a/test/rubygems/rubygems_plugin.rb b/test/rubygems/rubygems_plugin.rb index b538487bbf..c18f13d2ed 100644 --- a/test/rubygems/rubygems_plugin.rb +++ b/test/rubygems/rubygems_plugin.rb @@ -1,15 +1,6 @@ https://github.com/ruby/ruby/blob/trunk/test/rubygems/rubygems_plugin.rb#L1 # frozen_string_literal: true require "rubygems/command_manager" -## -# This is an example of exactly what NOT to do. -# -# DO NOT include code like this in your rubygems_plugin.rb - -module Gem::Commands - remove_const(:InterruptCommand) if defined?(InterruptCommand) -end - class Gem::Commands::InterruptCommand < Gem::Command def initialize super("interrupt", "Raises an Interrupt Exception", {}) diff --git a/test/rubygems/test_gem.rb b/test/rubygems/test_gem.rb index cc9d0a22d5..5e14ab86a9 100644 --- a/test/rubygems/test_gem.rb +++ b/test/rubygems/test_gem.rb @@ -20,8 +20,6 @@ class TestGem < Gem::TestCase https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem.rb#L20 common_installer_setup @additional = %w[a b].map {|d| File.join @tempdir, d } - - util_remove_interrupt_command end def test_self_finish_resolve @@ -1547,14 +1545,10 @@ class TestGem < Gem::TestCase https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem.rb#L1545 with_plugin("load") { Gem.load_env_plugins } assert_equal :loaded, TEST_PLUGIN_LOAD rescue nil - util_remove_interrupt_command - # Should attempt to cause a StandardError with_plugin("standarderror") { Gem.load_env_plugins } assert_equal :loaded, TEST_PLUGIN_STANDARDERROR rescue nil - util_remove_interrupt_command - # Should attempt to cause an Exception with_plugin("exception") { Gem.load_env_plugins } assert_equal :loaded, TEST_PLUGIN_EXCEPTION rescue nil @@ -2079,11 +2073,6 @@ You may need to `bundle install` to install missing gems https://github.com/ruby/ruby/blob/trunk/test/rubygems/test_gem.rb#L2073 spec end - def util_remove_interrupt_command - Gem::Commands.send :remove_const, :InterruptCommand if - Gem::Commands.const_defined? :InterruptCommand - end - def util_cache_dir File.join Gem.dir, "cache" end -- cgit v1.2.1 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/