ruby-changes:73611
From: Jimmy <ko1@a...>
Date: Mon, 19 Sep 2022 15:10:00 +0900 (JST)
Subject: [ruby-changes:73611] e75d963685 (master): Only exit if ruby2_keywords and splat together (#6395)
https://git.ruby-lang.org/ruby.git/commit/?id=e75d963685 From e75d96368577276cbebadb56a0fb286f66afdf3f Mon Sep 17 00:00:00 2001 From: Jimmy Miller <jimmy.miller@s...> Date: Mon, 19 Sep 2022 02:09:38 -0400 Subject: Only exit if ruby2_keywords and splat together (#6395) Before this change railsbench spent less time in yjit than before splat. This brings it back to parity. --- yjit/src/codegen.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/yjit/src/codegen.rs b/yjit/src/codegen.rs index 71831a96ed..ef7c3386a2 100644 --- a/yjit/src/codegen.rs +++ b/yjit/src/codegen.rs @@ -4370,7 +4370,7 @@ fn gen_send_iseq( https://github.com/ruby/ruby/blob/trunk/yjit/src/codegen.rs#L4370 // We are just going to not compile these. // https://www.rubydoc.info/stdlib/core/Proc:ruby2_keywords if unsafe { - get_iseq_flags_ruby2_keywords(jit.iseq) + get_iseq_flags_ruby2_keywords(jit.iseq) && flags & VM_CALL_ARGS_SPLAT != 0 } { gen_counter_incr!(asm, send_iseq_ruby2_keywords); return CantCompile; -- cgit v1.2.1 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/