[前][次][番号順一覧][スレッド一覧]

ruby-changes:73532

From: David <ko1@a...>
Date: Mon, 12 Sep 2022 22:13:50 +0900 (JST)
Subject: [ruby-changes:73532] 2aa8edaec7 (master): [rubygems/rubygems] Deduplicate results just once

https://git.ruby-lang.org/ruby.git/commit/?id=2aa8edaec7

From 2aa8edaec701ca2d76e7be7a9b792b69574ac869 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...>
Date: Fri, 9 Sep 2022 00:05:49 +0200
Subject: [rubygems/rubygems] Deduplicate results just once

Instead of checking for uniqueness for every spec.

https://github.com/rubygems/rubygems/commit/97d28c9665
---
 lib/bundler/index.rb | 13 +++----------
 1 file changed, 3 insertions(+), 10 deletions(-)

diff --git a/lib/bundler/index.rb b/lib/bundler/index.rb
index 9c48c9032b..d3743adb68 100644
--- a/lib/bundler/index.rb
+++ b/lib/bundler/index.rb
@@ -58,19 +58,12 @@ module Bundler https://github.com/ruby/ruby/blob/trunk/lib/bundler/index.rb#L58
     # about, returning all of the results.
     def search(query)
       results = local_search(query)
-
-      seen = results.map(&:full_name).uniq unless @sources.empty?
+      return results unless @sources.any?
 
       @sources.each do |source|
-        source.search(query).each do |spec|
-          next if seen.include?(spec.full_name)
-
-          seen << spec.full_name
-          results << spec
-        end
+        results.concat(source.search(query))
       end
-
-      results
+      results.uniq(&:full_name)
     end
 
     def local_search(query)
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]