ruby-changes:7341
From: naruse <ko1@a...>
Date: Tue, 26 Aug 2008 11:45:22 +0900 (JST)
Subject: [ruby-changes:7341] Ruby:r18860 (trunk): * lib/cgi.rb (nOE_element_def): fix error when cascade methods which
naruse 2008-08-26 11:42:27 +0900 (Tue, 26 Aug 2008) New Revision: 18860 http://svn.ruby-lang.org/cgi-bin/viewvc.cgi?view=rev&revision=18860 Log: * lib/cgi.rb (nOE_element_def): fix error when cascade methods which don't have arguments. Patch by Takeyuki Fujioka. [ruby-dev:35964] * lib/cgi.rb (blockquote): String#collect (this depends on String#each) is no longer exists. Patch by Takeyuki Fujioka. [ruby-dev:35946] * lib/cgi.rb (blockquote): ditto. Modified files: trunk/ChangeLog trunk/lib/cgi.rb Index: ChangeLog =================================================================== --- ChangeLog (revision 18859) +++ ChangeLog (revision 18860) @@ -1,3 +1,14 @@ +Tue Aug 26 11:33:30 2008 NARUSE, Yui <naruse@r...> + + * lib/cgi.rb (nOE_element_def): fix error when cascade methods which + don't have arguments. Patch by Takeyuki Fujioka. [ruby-dev:35964] + + * lib/cgi.rb (blockquote): String#collect (this depends on + String#each) is no longer exists. + Patch by Takeyuki Fujioka. [ruby-dev:35946] + + * lib/cgi.rb (blockquote): ditto. + Tue Aug 26 03:06:48 2008 Tanaka Akira <akr@f...> * io.c (make_writeconv): copy invalid/undef flags. Index: lib/cgi.rb =================================================================== --- lib/cgi.rb (revision 18859) +++ lib/cgi.rb (revision 18860) @@ -1283,6 +1283,7 @@ # - O EMPTY def nOE_element_def(element, append = nil) s = <<-END + attributes={attributes=>nil} if attributes.kind_of?(String) "<#{element.upcase}" + attributes.collect{|name, value| next unless value " " + CGI::escapeHTML(name) + @@ -1389,11 +1390,11 @@ # # blockquote("http://www.example.com/quotes/foo.html") { "Foo!" } # #=> "<BLOCKQUOTE CITE=\"http://www.example.com/quotes/foo.html\">Foo!</BLOCKQUOTE> - def blockquote(cite = nil) # :yield: + def blockquote(cite = {}) # :yield: attributes = if cite.kind_of?(String) { "CITE" => cite } else - cite or "" + cite end if block_given? super(attributes){ yield } @@ -1413,11 +1414,11 @@ # # caption("left") { "Capital Cities" } # # => <CAPTION ALIGN=\"left\">Capital Cities</CAPTION> - def caption(align = nil) # :yield: + def caption(align = {}) # :yield: attributes = if align.kind_of?(String) { "ALIGN" => align } else - align or "" + align end if block_given? super(attributes){ yield } -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/