ruby-changes:73278
From: Maxime <ko1@a...>
Date: Tue, 30 Aug 2022 01:07:32 +0900 (JST)
Subject: [ruby-changes:73278] 8c45b8a989 (master): Update asm comments for gen_send_iseq
https://git.ruby-lang.org/ruby.git/commit/?id=8c45b8a989 From 8c45b8a989fea4c74d68c464a55aa54e9144994a Mon Sep 17 00:00:00 2001 From: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@s...> Date: Wed, 10 Aug 2022 13:37:49 -0400 Subject: Update asm comments for gen_send_iseq --- yjit/src/codegen.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yjit/src/codegen.rs b/yjit/src/codegen.rs index 83d09362d1..d8998b9a98 100644 --- a/yjit/src/codegen.rs +++ b/yjit/src/codegen.rs @@ -4514,11 +4514,11 @@ fn gen_send_iseq( https://github.com/ruby/ruby/blob/trunk/yjit/src/codegen.rs#L4514 asm.store(Opnd::mem(64, callee_sp, offs), Qnil.into()); } - asm.comment("push env"); - // Put compile time cme into REG1. It's assumed to be valid because we are notified when + // Write the callee CME on the stack. It's assumed to be valid because we are notified when // any cme we depend on become outdated. See yjit_method_lookup_change(). // Write method entry at sp[-3] // sp[-3] = me; + asm.comment("push cme, block handler, frame type"); asm.store(Opnd::mem(64, callee_sp, SIZEOF_VALUE_I32 * -3), VALUE(cme as usize).into()); // Write block handler at sp[-2] @@ -4540,7 +4540,7 @@ fn gen_send_iseq( https://github.com/ruby/ruby/blob/trunk/yjit/src/codegen.rs#L4540 let frame_type = VM_FRAME_MAGIC_METHOD | VM_ENV_FLAG_LOCAL; asm.store(Opnd::mem(64, callee_sp, SIZEOF_VALUE_I32 * -1), frame_type.into()); - asm.comment("push callee CFP"); + asm.comment("push callee control frame"); // Allocate a new CFP (ec->cfp--) let new_cfp = asm.sub(CFP, (RUBY_SIZEOF_CONTROL_FRAME as u64).into()); asm.mov(CFP, new_cfp); -- cgit v1.2.1 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/