[前][次][番号順一覧][スレッド一覧]

ruby-changes:73079

From: Takashi <ko1@a...>
Date: Sun, 28 Aug 2022 02:23:20 +0900 (JST)
Subject: [ruby-changes:73079] 458d49a04a (master): Ignore rm -rf failure

https://git.ruby-lang.org/ruby.git/commit/?id=458d49a04a

From 458d49a04ab7ce8a61be11fbaf341ee252b8253a Mon Sep 17 00:00:00 2001
From: Takashi Kokubun <takashikkbn@g...>
Date: Sat, 27 Aug 2022 10:21:23 -0700
Subject: Ignore rm -rf failure

http://ci.rvm.jp/results/trunk-mjit@phosphorus-docker/4213386

It's failing with:
rm: cannot remove '/tmp/ruby/v3/build/trunk-mjit/tmp/test_rubygems_20220827-13666-ii8lcp': Directory not empty
rm: cannot remove '/tmp/ruby/v3/build/trunk-mjit/tmp/test_rubygems_20220827-13666-fy77y1': Directory not empty

I'd like to make sure the following `ENV.replace` is called and see if
there's any other issues.
---
 test/rubygems/helper.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/rubygems/helper.rb b/test/rubygems/helper.rb
index b9bc72a1f3..23ea69ae0b 100644
--- a/test/rubygems/helper.rb
+++ b/test/rubygems/helper.rb
@@ -467,7 +467,7 @@ class Gem::TestCase < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/rubygems/helper.rb#L467
 
     # FileUtils.rm_rf randomly fails on ci.rvm.jp trunk-mjit
     if ENV['RUBY_DEBUG']&.include?('ci')
-      system('rm', '-rf', @tempdir.shellescape, exception: true)
+      system('rm', '-rf', @tempdir)
     else
       FileUtils.rm_rf @tempdir
     end
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]