[前][次][番号順一覧][スレッド一覧]

ruby-changes:72734

From: Takashi <ko1@a...>
Date: Fri, 29 Jul 2022 08:15:28 +0900 (JST)
Subject: [ruby-changes:72734] 0d68286be9 (master): Revert "Try reproducing the MinGW hang on time command (#6168)"

https://git.ruby-lang.org/ruby.git/commit/?id=0d68286be9

From 0d68286be93b2c7e588e42849ead0526ff55126c Mon Sep 17 00:00:00 2001
From: Takashi Kokubun <takashikkbn@g...>
Date: Thu, 28 Jul 2022 16:12:46 -0700
Subject: Revert "Try reproducing the MinGW hang on time command (#6168)"

This reverts commit bee5089d6789401f265f87b2f23f1bd7ec63cec8.

Looking at https://github.com/ruby/ruby/runs/7564065637?check_suite_focus=true,
we concluded that the ruby process for test-all is stuck before exit
when this issue reproduces.

However, because of our limited bandwidth to support MinGW, we're not
investigating this, and therefore we need to keep skipping tests that
hang on this environment.
---
 .github/workflows/mingw.yml | 2 +-
 test/rinda/test_rinda.rb    | 7 +++++++
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/.github/workflows/mingw.yml b/.github/workflows/mingw.yml
index 2842a19f48..80b7a92f15 100644
--- a/.github/workflows/mingw.yml
+++ b/.github/workflows/mingw.yml
@@ -135,7 +135,7 @@ jobs: https://github.com/ruby/ruby/blob/trunk/.github/workflows/mingw.yml#L135
         run: |
           # Actions uses UTF8, causes test failures, similar to normal OS setup
           chcp.com 437
-          time make ${{ StartsWith(matrix.test_task, 'test/') && matrix.test_task || 'test-all' }}
+          make ${{ StartsWith(matrix.test_task, 'test/') && matrix.test_task || 'test-all' }}
         env:
           RUBY_TESTOPTS: >-
             -j${{env.TEST_JOBS}} --retry --job-status=normal --show-skip --timeout-scale=1.5
diff --git a/test/rinda/test_rinda.rb b/test/rinda/test_rinda.rb
index d937cd0f45..d8340e0fc4 100644
--- a/test/rinda/test_rinda.rb
+++ b/test/rinda/test_rinda.rb
@@ -496,6 +496,10 @@ class TupleSpaceProxyTest < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/rinda/test_rinda.rb#L496
   include TupleSpaceTestModule
 
   def setup
+    if RUBY_PLATFORM.match?(/mingw/)
+      @omitted = true
+      omit 'This test seems to randomly hang on GitHub Actions MinGW UCRT64'
+    end
     super
     ThreadGroup.new.add(Thread.current)
     @ts_base = Rinda::TupleSpace.new(1)
@@ -503,6 +507,9 @@ class TupleSpaceProxyTest < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/rinda/test_rinda.rb#L507
     @server = DRb.start_service("druby://localhost:0")
   end
   def teardown
+    return if @omitted
+    @omitted = false
+
     # implementation-dependent
     @ts_base.instance_eval{
       if th = @keeper
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]