[前][次][番号順一覧][スレッド一覧]

ruby-changes:72578

From: David <ko1@a...>
Date: Sun, 17 Jul 2022 17:47:40 +0900 (JST)
Subject: [ruby-changes:72578] 3cfc3fcf96 (master): [rubygems/rubygems] Unify some common code

https://git.ruby-lang.org/ruby.git/commit/?id=3cfc3fcf96

From 3cfc3fcf96a414fc1a966eacc57a282aa2580547 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...>
Date: Fri, 15 Jul 2022 21:34:51 +0200
Subject: [rubygems/rubygems] Unify some common code

https://github.com/rubygems/rubygems/commit/972e8ff965
---
 lib/bundler/rubygems_gem_installer.rb | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/lib/bundler/rubygems_gem_installer.rb b/lib/bundler/rubygems_gem_installer.rb
index d0a88ae7c7..098ef0a356 100644
--- a/lib/bundler/rubygems_gem_installer.rb
+++ b/lib/bundler/rubygems_gem_installer.rb
@@ -67,7 +67,7 @@ module Bundler https://github.com/ruby/ruby/blob/trunk/lib/bundler/rubygems_gem_installer.rb#L67
     def build_extensions
       extension_cache_path = options[:bundler_extension_cache_path]
       unless extension_cache_path && extension_dir = spec.extension_dir
-        require "shellwords" unless Bundler.rubygems.provides?(">= 3.2.25")
+        prepare_extension_build
         return super
       end
 
@@ -79,7 +79,7 @@ module Bundler https://github.com/ruby/ruby/blob/trunk/lib/bundler/rubygems_gem_installer.rb#L79
           FileUtils.cp_r extension_cache_path, spec.extension_dir
         end
       else
-        require "shellwords" # compensate missing require in rubygems before version 3.2.25
+        prepare_extension_build
         super
         SharedHelpers.filesystem_access(extension_cache_path.parent, &:mkpath)
         SharedHelpers.filesystem_access(extension_cache_path) do
@@ -98,6 +98,10 @@ module Bundler https://github.com/ruby/ruby/blob/trunk/lib/bundler/rubygems_gem_installer.rb#L98
 
     private
 
+    def prepare_extension_build
+      require "shellwords" unless Bundler.rubygems.provides?(">= 3.2.25")
+    end
+
     def strict_rm_rf(dir)
       Bundler.rm_rf dir
     rescue Errno::ENOTEMPTY => e
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]