[前][次][番号順一覧][スレッド一覧]

ruby-changes:72546

From: Nobuyoshi <ko1@a...>
Date: Thu, 14 Jul 2022 17:14:02 +0900 (JST)
Subject: [ruby-changes:72546] 8b64e8f2ed (master): [ruby/set] Get rid of use of `Gem::Version`

https://git.ruby-lang.org/ruby.git/commit/?id=8b64e8f2ed

From 8b64e8f2ed5833570bd1f46683d2b96c7c98413a Mon Sep 17 00:00:00 2001
From: Nobuyoshi Nakada <nobu@r...>
Date: Fri, 8 Jul 2022 22:29:23 +0900
Subject: [ruby/set] Get rid of use of `Gem::Version`

When retrying in ruby's test, it seems possible that `Gem` is not
loaded.

```
  1) Error:
TC_Set_Builtin#test_to_set:
NameError: uninitialized constant TC_Set_Builtin::Gem
    /export/home/chkbuild/chkbuild-gcc/tmp/build/20220708T070011Z/ruby/test/test_set.rb:844:in `should_omit?'
    /export/home/chkbuild/chkbuild-gcc/tmp/build/20220708T070011Z/ruby/test/test_set.rb:869:in `test_to_set'

  2) Error:
TC_Set_Builtin#test_Set:
NameError: uninitialized constant TC_Set_Builtin::Gem
    /export/home/chkbuild/chkbuild-gcc/tmp/build/20220708T070011Z/ruby/test/test_set.rb:844:in `should_omit?'
    /export/home/chkbuild/chkbuild-gcc/tmp/build/20220708T070011Z/ruby/test/test_set.rb:849:in
    `test_Set'
```

This is by `Gem::Version` only, just compare as array of integers
instead.

https://github.com/ruby/set/commit/cde0a4bbc7
---
 test/test_set.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/test/test_set.rb b/test/test_set.rb
index 83e28878a0..164dc460a7 100644
--- a/test/test_set.rb
+++ b/test/test_set.rb
@@ -841,7 +841,7 @@ end https://github.com/ruby/ruby/blob/trunk/test/test_set.rb#L841
 
 class TC_Set_Builtin < Test::Unit::TestCase
   private def should_omit?
-    Gem::Version.new(RUBY_VERSION) < Gem::Version.new('3.2.0') ||
+    (RUBY_VERSION.scan(/\d+/).map(&:to_i) <=> [3, 2]) < 0 ||
       !File.exist?(File.expand_path('../prelude.rb', __dir__))
   end
 
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]