[前][次][番号順一覧][スレッド一覧]

ruby-changes:72209

From: David <ko1@a...>
Date: Fri, 17 Jun 2022 17:05:31 +0900 (JST)
Subject: [ruby-changes:72209] 5450b409fc (master): [rubygems/rubygems] Remove part of comment that fell out of date

https://git.ruby-lang.org/ruby.git/commit/?id=5450b409fc

From 5450b409fc917327373adb573bc5df5948f4202c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...>
Date: Tue, 14 Jun 2022 16:47:55 +0200
Subject: [rubygems/rubygems] Remove part of comment that fell out of date

https://github.com/rubygems/rubygems/commit/272ac23aa8
---
 lib/rubygems/ext/cargo_builder.rb    | 9 ++-------
 lib/rubygems/ext/ext_conf_builder.rb | 9 ++-------
 2 files changed, 4 insertions(+), 14 deletions(-)

diff --git a/lib/rubygems/ext/cargo_builder.rb b/lib/rubygems/ext/cargo_builder.rb
index a08830319d..3a744c5612 100644
--- a/lib/rubygems/ext/cargo_builder.rb
+++ b/lib/rubygems/ext/cargo_builder.rb
@@ -253,14 +253,9 @@ class Gem::Ext::CargoBuilder < Gem::Ext::Builder https://github.com/ruby/ruby/blob/trunk/lib/rubygems/ext/cargo_builder.rb#L253
       tmp_dest = Dir.mktmpdir(".gem.", extension_dir)
 
       # Some versions of `mktmpdir` return absolute paths, which will break make
-      # if the paths contain spaces. However, on Ruby 1.9.x on Windows, relative
-      # paths cause all C extension builds to fail.
+      # if the paths contain spaces.
       #
-      # As such, we convert to a relative path unless we are using Ruby 1.9.x on
-      # Windows. This means that when using Ruby 1.9.x on Windows, paths with
-      # spaces do not work.
-      #
-      # Details: https://github.com/rubygems/rubygems/issues/977#issuecomment-171544940
+      # As such, we convert to a relative path.
       tmp_dest_relative = get_relative_path(tmp_dest.clone, extension_dir)
 
       full_tmp_dest = File.join(extension_dir, tmp_dest_relative)
diff --git a/lib/rubygems/ext/ext_conf_builder.rb b/lib/rubygems/ext/ext_conf_builder.rb
index 52972b901b..41a1d844fe 100644
--- a/lib/rubygems/ext/ext_conf_builder.rb
+++ b/lib/rubygems/ext/ext_conf_builder.rb
@@ -13,14 +13,9 @@ class Gem::Ext::ExtConfBuilder < Gem::Ext::Builder https://github.com/ruby/ruby/blob/trunk/lib/rubygems/ext/ext_conf_builder.rb#L13
     tmp_dest = Dir.mktmpdir(".gem.", extension_dir)
 
     # Some versions of `mktmpdir` return absolute paths, which will break make
-    # if the paths contain spaces. However, on Ruby 1.9.x on Windows, relative
-    # paths cause all C extension builds to fail.
+    # if the paths contain spaces.
     #
-    # As such, we convert to a relative path unless we are using Ruby 1.9.x on
-    # Windows. This means that when using Ruby 1.9.x on Windows, paths with
-    # spaces do not work.
-    #
-    # Details: https://github.com/rubygems/rubygems/issues/977#issuecomment-171544940
+    # As such, we convert to a relative path.
     tmp_dest_relative = get_relative_path(tmp_dest.clone, extension_dir)
 
     destdir = ENV["DESTDIR"]
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]