[前][次][番号順一覧][スレッド一覧]

ruby-changes:71004

From: David <ko1@a...>
Date: Tue, 25 Jan 2022 08:50:53 +0900 (JST)
Subject: [ruby-changes:71004] de678cd51e (master): [ruby/pathname] Officially drop support for ruby 2.6 or older

https://git.ruby-lang.org/ruby.git/commit/?id=de678cd51e

From de678cd51e2e73c2edaced5f824e93c6a91a0f85 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...>
Date: Thu, 18 Nov 2021 21:45:04 +0100
Subject: [ruby/pathname] Officially drop support for ruby 2.6 or older

The gem doesn't even install on old rubies, but since the gemspec claims
it's supported, `gem install pathname` will try to install it and print
an error.

This commit doesn't fix the above issue. The only way to fix it would be
to restore support and release a new version that actually supports old
rubies. However, such a change has been proposed and ignored for a long
time.

So this issue proposes to leave that broken but at least bring the
gemspec manifest and the CI matrix in sync to hopefully avoid this issue
from happening again in the future.

https://github.com/ruby/pathname/commit/3ee010b538
---
 ext/pathname/pathname.gemspec | 2 +-
 tool/lib/core_assertions.rb   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ext/pathname/pathname.gemspec b/ext/pathname/pathname.gemspec
index 5aaa8f8dd71..c9c0b84e690 100644
--- a/ext/pathname/pathname.gemspec
+++ b/ext/pathname/pathname.gemspec
@@ -7,7 +7,7 @@ Gem::Specification.new do |spec| https://github.com/ruby/ruby/blob/trunk/ext/pathname/pathname.gemspec#L7
   spec.summary       = %q{Representation of the name of a file or directory on the filesystem}
   spec.description   = %q{Representation of the name of a file or directory on the filesystem}
   spec.homepage      = "https://github.com/ruby/pathname"
-  spec.required_ruby_version = Gem::Requirement.new(">= 2.3.0")
+  spec.required_ruby_version = Gem::Requirement.new(">= 2.7.0")
   spec.licenses      = ["Ruby", "BSD-2-Clause"]
 
   spec.metadata["homepage_uri"] = spec.homepage
diff --git a/tool/lib/core_assertions.rb b/tool/lib/core_assertions.rb
index 9adc936ad8d..51cb7ebf0dd 100644
--- a/tool/lib/core_assertions.rb
+++ b/tool/lib/core_assertions.rb
@@ -691,7 +691,7 @@ eom https://github.com/ruby/ruby/blob/trunk/tool/lib/core_assertions.rb#L691
           msg = "exceptions on #{errs.length} threads:\n" +
             errs.map {|t, err|
             "#{t.inspect}:\n" +
-              RUBY_VERSION >= "2.5.0" ? err.full_message(highlight: false, order: :top) : err.message
+              err.full_message(highlight: false, order: :top)
           }.join("\n---\n")
           if message
             msg = "#{message}\n#{msg}"
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]