[前][次][番号順一覧][スレッド一覧]

ruby-changes:70962

From: Koichi <ko1@a...>
Date: Fri, 21 Jan 2022 17:39:29 +0900 (JST)
Subject: [ruby-changes:70962] 5e3a320218 (master): respect `--quiet` option for btest

https://git.ruby-lang.org/ruby.git/commit/?id=5e3a320218

From 5e3a32021849718ae483eaaa9fbf155f91828039 Mon Sep 17 00:00:00 2001
From: Koichi Sasada <ko1@a...>
Date: Fri, 21 Jan 2022 17:38:11 +0900
Subject: respect `--quiet` option for btest

Do not print anymore except errors.
---
 bootstraptest/runner.rb     | 26 ++++++++++++++++++--------
 bootstraptest/test_fiber.rb |  2 +-
 2 files changed, 19 insertions(+), 9 deletions(-)

diff --git a/bootstraptest/runner.rb b/bootstraptest/runner.rb
index b155db18aa7..acc113b7290 100755
--- a/bootstraptest/runner.rb
+++ b/bootstraptest/runner.rb
@@ -187,8 +187,10 @@ def exec_test(pathes) https://github.com/ruby/ruby/blob/trunk/bootstraptest/runner.rb#L187
   @width = pathes.map {|path| File.basename(path).size}.max + 2
   pathes.each do |path|
     @basename = File.basename(path)
-    $stderr.printf("%s%-*s ", erase(@quiet), @width, @basename)
-    $stderr.flush
+    unless @quiet
+      $stderr.printf("%s%-*s ", erase(@quiet), @width, @basename)
+      $stderr.flush
+    end
     @columns = @width + 1
     $stderr.puts if @verbose
     count = @count
@@ -198,14 +200,14 @@ def exec_test(pathes) https://github.com/ruby/ruby/blob/trunk/bootstraptest/runner.rb#L200
       if @error == error
         msg = "PASS #{@count-count}"
         @columns += msg.size - 1
-        $stderr.print "#{@progress_bs}#{@passed}#{msg}#{@reset}"
+        $stderr.print "#{@progress_bs}#{@passed}#{msg}#{@reset}" unless @quiet
       else
         msg = "FAIL #{@error-error}/#{@count-count}"
         $stderr.print "#{@progress_bs}#{@failed}#{msg}#{@reset}"
         @columns = 0
       end
     end
-    $stderr.puts unless @quiet and @tty and @error == error
+    $stderr.puts if !@quiet and (@tty or @error == error)
   end
   $stderr.print(erase) if @quiet
   @errbuf.each do |msg|
@@ -213,9 +215,13 @@ def exec_test(pathes) https://github.com/ruby/ruby/blob/trunk/bootstraptest/runner.rb#L215
   end
   if @error == 0
     if @count == 0
-      $stderr.puts "No tests, no problem"
+      $stderr.puts "No tests, no problem" unless @quiet
     else
-      $stderr.puts "#{@passed}PASS#{@reset} all #{@count} tests"
+      if @quiet
+        $stdout.puts "#{@passed}PASS#{@reset} all #{@count} tests"
+      else
+        $stderr.puts "#{@passed}PASS#{@reset} all #{@count} tests"
+      end
     end
     exit true
   else
@@ -225,7 +231,9 @@ def exec_test(pathes) https://github.com/ruby/ruby/blob/trunk/bootstraptest/runner.rb#L231
 end
 
 def show_progress(message = '')
-  if @verbose
+  if @quiet
+    # do nothing
+  elsif @verbose
     $stderr.print "\##{@count} #{@location} "
   elsif @tty
     $stderr.print "#{@progress_bs}#{@progress[@count % @progress.size]}"
@@ -234,7 +242,9 @@ def show_progress(message = '') https://github.com/ruby/ruby/blob/trunk/bootstraptest/runner.rb#L242
   faildesc, errout = with_stderr {yield}
   t = Time.now - t if @verbose
   if !faildesc
-    if @tty
+    if @quiet
+      # do nothing
+    elsif @tty
       $stderr.print "#{@progress_bs}#{@progress[@count % @progress.size]}"
     elsif @verbose
       $stderr.printf(". %.3f\n", t)
diff --git a/bootstraptest/test_fiber.rb b/bootstraptest/test_fiber.rb
index 2614dd13bf1..f651050b96c 100644
--- a/bootstraptest/test_fiber.rb
+++ b/bootstraptest/test_fiber.rb
@@ -10,7 +10,7 @@ show_limit %q{ https://github.com/ruby/ruby/blob/trunk/bootstraptest/test_fiber.rb#L10
     puts "Fiber count: #{fibers.count} (#{error})"
     break
   end while true
-}
+} unless @quiet
 
 assert_equal %q{ok}, %q{
   Fiber.new{
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]