ruby-changes:70916
From: Yusuke <ko1@a...>
Date: Thu, 20 Jan 2022 01:05:05 +0900 (JST)
Subject: [ruby-changes:70916] 26e0450ba9 (master): [rubygems/rubygems] Add spec to class name definition in newgem spec
https://git.ruby-lang.org/ruby.git/commit/?id=26e0450ba9 From 26e0450ba9296540e044df5fd91c8856919d4a6c Mon Sep 17 00:00:00 2001 From: Yusuke Nakamura <yusuke1994525@g...> Date: Sat, 15 Jan 2022 02:55:41 +0900 Subject: [rubygems/rubygems] Add spec to class name definition in newgem spec https://github.com/rubygems/rubygems/commit/5f698fc4a0 --- spec/bundler/commands/newgem_spec.rb | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/spec/bundler/commands/newgem_spec.rb b/spec/bundler/commands/newgem_spec.rb index a41a0de508d..49ab4a366d5 100644 --- a/spec/bundler/commands/newgem_spec.rb +++ b/spec/bundler/commands/newgem_spec.rb @@ -30,6 +30,8 @@ RSpec.describe "bundle gem" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/commands/newgem_spec.rb#L30 let(:minitest_test_file_path) { "test/test_mygem.rb" } + let(:minitest_test_class_name) { "class TestMygem < Minitest::Test" } + before do sys_exec("git config --global user.name 'Bundler User'") sys_exec("git config --global user.email user@e...") @@ -736,6 +738,10 @@ RSpec.describe "bundle gem" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/commands/newgem_spec.rb#L738 expect(bundled_app("#{gem_name}/#{minitest_test_file_path}").read).to include(%(require "test_helper")) end + it "defines valid test class name" do + expect(bundled_app("#{gem_name}/#{minitest_test_file_path}").read).to include(minitest_test_class_name) + end + it "creates a default test which fails" do expect(bundled_app("#{gem_name}/#{minitest_test_file_path}").read).to include("assert false") end @@ -1304,6 +1310,8 @@ RSpec.describe "bundle gem" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/commands/newgem_spec.rb#L1310 let(:minitest_test_file_path) { "test/test_test_gem.rb" } + let(:minitest_test_class_name) { "class TestTestGem < Minitest::Test" } + let(:flags) { nil } it "does not nest constants" do @@ -1361,6 +1369,8 @@ RSpec.describe "bundle gem" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/commands/newgem_spec.rb#L1369 let(:minitest_test_file_path) { "test/test/test_gem.rb" } + let(:minitest_test_class_name) { "class TestTestGem < Minitest::Test" } + it "nests constants so they work" do bundle "gem #{gem_name}" expect(bundled_app("#{gem_name}/lib/#{require_path}/version.rb").read).to match(/module Test\n module Gem/) -- cgit v1.2.1 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/