[前][次][番号順一覧][スレッド一覧]

ruby-changes:70736

From: Kazuhiro <ko1@a...>
Date: Wed, 5 Jan 2022 09:00:54 +0900 (JST)
Subject: [ruby-changes:70736] 13241b71a5 (master): Fix failures on ruby 3.1

https://git.ruby-lang.org/ruby.git/commit/?id=13241b71a5

From 13241b71a50dded0a7b021ec4f2fb6a995daace9 Mon Sep 17 00:00:00 2001
From: Kazuhiro NISHIYAMA <zn@m...>
Date: Wed, 5 Jan 2022 08:18:47 +0900
Subject: Fix failures on ruby 3.1

Because https://github.com/ruby/ruby/pull/5148 merged after Ruby 3.1.0 released.

https://github.com/ruby/actions/runs/4705986643?check_suite_focus=true#step:18:144
```
  1)
  Method#parameters adds * rest arg for "star" argument FAILED
  Expected [[:rest]] == [[:rest, :*]]
  to be truthy but was false
  /home/runner/work/actions/actions/snapshot-ruby_3_1/spec/ruby/core/method/parameters_spec.rb:228:in `block (3 levels) in <top (required)>'
  /home/runner/work/actions/actions/snapshot-ruby_3_1/spec/ruby/core/method/parameters_spec.rb:4:in `<top (required)>'

  2)
  Proc#parameters adds * rest arg for "star" argument FAILED
  Expected [[:req, :x], [:rest]] == [[:req, :x], [:rest, :*]]
  to be truthy but was false
  /home/runner/work/actions/actions/snapshot-ruby_3_1/spec/ruby/core/proc/parameters_spec.rb:85:in `block (3 levels) in <top (required)>'
  /home/runner/work/actions/actions/snapshot-ruby_3_1/spec/ruby/core/proc/parameters_spec.rb:3:in `<top (required)>'
```
---
 spec/ruby/core/method/parameters_spec.rb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/spec/ruby/core/method/parameters_spec.rb b/spec/ruby/core/method/parameters_spec.rb
index 67b42afafa6..e6d51d1b4d2 100644
--- a/spec/ruby/core/method/parameters_spec.rb
+++ b/spec/ruby/core/method/parameters_spec.rb
@@ -222,14 +222,14 @@ describe "Method#parameters" do https://github.com/ruby/ruby/blob/trunk/spec/ruby/core/method/parameters_spec.rb#L222
     m.method(:handled_via_method_missing).parameters.should == [[:rest]]
   end
 
-  ruby_version_is '3.1' do
+  ruby_version_is '3.2' do
     it "adds * rest arg for \"star\" argument" do
       m = MethodSpecs::Methods.new
       m.method(:one_unnamed_splat).parameters.should == [[:rest, :*]]
     end
   end
 
-  ruby_version_is ''...'3.1' do
+  ruby_version_is ''...'3.2' do
     it "adds nameless rest arg for \"star\" argument" do
       m = MethodSpecs::Methods.new
       m.method(:one_unnamed_splat).parameters.should == [[:rest]]
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]