[前][次][番号順一覧][スレッド一覧]

ruby-changes:70726

From: Christian <ko1@a...>
Date: Tue, 4 Jan 2022 23:09:13 +0900 (JST)
Subject: [ruby-changes:70726] 11b1ebe606 (master): [ruby/error_highlight] Fix the spurious TypeError.

https://git.ruby-lang.org/ruby.git/commit/?id=11b1ebe606

From 11b1ebe606a82bcdcb4ff5568f0302c5470d0048 Mon Sep 17 00:00:00 2001
From: Christian Boos <cboos@b...>
Date: Wed, 29 Dec 2021 22:10:21 +0000
Subject: [ruby/error_highlight] Fix the spurious TypeError.

When we have no backtrace locations, we can't have the highlight,
so just return the message.

https://github.com/ruby/error_highlight/commit/9f5c639494
---
 lib/error_highlight/core_ext.rb              | 1 +
 test/error_highlight/test_error_highlight.rb | 3 ---
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/error_highlight/core_ext.rb b/lib/error_highlight/core_ext.rb
index d3a4dbacd64..78cda8ace29 100644
--- a/lib/error_highlight/core_ext.rb
+++ b/lib/error_highlight/core_ext.rb
@@ -15,6 +15,7 @@ module ErrorHighlight https://github.com/ruby/ruby/blob/trunk/lib/error_highlight/core_ext.rb#L15
       return msg unless locs
 
       loc = locs.first
+      return msg unless loc
       begin
         node = RubyVM::AbstractSyntaxTree.of(loc, keep_script_lines: true)
         opts = {}
diff --git a/test/error_highlight/test_error_highlight.rb b/test/error_highlight/test_error_highlight.rb
index 222da0fc792..d31e394e780 100644
--- a/test/error_highlight/test_error_highlight.rb
+++ b/test/error_highlight/test_error_highlight.rb
@@ -1198,9 +1198,6 @@ undefined method `time' for 1:Integer https://github.com/ruby/ruby/blob/trunk/test/error_highlight/test_error_highlight.rb#L1198
   def test_simulate_funcallv_from_embedded_ruby
     assert_error_message(NoMethodError, <<~END) do
 undefined method `foo' for nil:NilClass
-
-      nil.foo + 1
-         ^^^^
     END
 
       nil.foo + 1
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]