[前][次][番号順一覧][スレッド一覧]

ruby-changes:70371

From: Kazuki <ko1@a...>
Date: Tue, 21 Dec 2021 00:11:39 +0900 (JST)
Subject: [ruby-changes:70371] 6b67f06312 (master): test/fiber/test_io_buffer.rb: fix file descriptor leaks

https://git.ruby-lang.org/ruby.git/commit/?id=6b67f06312

From 6b67f0631284b1be8e56e20ec133a1b3386fc090 Mon Sep 17 00:00:00 2001
From: Kazuki Yamaguchi <k@r...>
Date: Mon, 20 Dec 2021 23:59:34 +0900
Subject: test/fiber/test_io_buffer.rb: fix file descriptor leaks

I got the warning while running "make test-all":

	Leaked file descriptor: TestFiberIOBuffer#test_write_nonblock: 9 : #<UNIXSocket:fd 9>
	Closed file descriptor: TestFiberIOBuffer#test_read_write_blocking: 9
	Leaked file descriptor: TestFiberIOBuffer#test_timeout_after: 10 : #<UNIXSocket:fd 10>
	Closed file descriptor: TestFiberIOBuffer#test_read_nonblock: 10
---
 test/fiber/test_io_buffer.rb | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/test/fiber/test_io_buffer.rb b/test/fiber/test_io_buffer.rb
index e48764242fd..5b34a37331b 100644
--- a/test/fiber/test_io_buffer.rb
+++ b/test/fiber/test_io_buffer.rb
@@ -36,6 +36,9 @@ class TestFiberIOBuffer < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/fiber/test_io_buffer.rb#L36
     assert_equal MESSAGE, message
     assert_predicate(i, :closed?)
     assert_predicate(o, :closed?)
+  ensure
+    i&.close
+    o&.close
   end
 
   def test_timeout_after
@@ -67,6 +70,9 @@ class TestFiberIOBuffer < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/fiber/test_io_buffer.rb#L70
 
     assert_nil message
     assert_kind_of Timeout::Error, error
+  ensure
+    i&.close
+    o&.close
   end
 
   def test_read_nonblock
@@ -89,7 +95,9 @@ class TestFiberIOBuffer < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/fiber/test_io_buffer.rb#L95
     thread.join
 
     assert_equal :wait_readable, message
-    o.close
+  ensure
+    i&.close
+    o&.close
   end
 
   def test_write_nonblock
@@ -110,5 +118,8 @@ class TestFiberIOBuffer < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/fiber/test_io_buffer.rb#L118
     thread.join
 
     assert_equal MESSAGE, i.read
+  ensure
+    i&.close
+    o&.close
   end
 end
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]