ruby-changes:70056
From: Alan <ko1@a...>
Date: Sun, 5 Dec 2021 01:35:53 +0900 (JST)
Subject: [ruby-changes:70056] 34b5e2566d (master): YJIT: Enable out of memory tests
https://git.ruby-lang.org/ruby.git/commit/?id=34b5e2566d From 34b5e2566da88c392ada07437c3e8b44c295c9b2 Mon Sep 17 00:00:00 2001 From: Alan Wu <XrXr@u...> Date: Tue, 30 Nov 2021 18:11:42 -0500 Subject: YJIT: Enable out of memory tests As of [1] and [2], YJIT has enough support for out of memory conditions to pass these two basic tests. OOM code paths are prone to bugs since they are rarely exercised in common workloads. We might want to add CI runs that stress test these code paths. Maybe outside of GitHub Actions for capacity reasons. [1]: f41b4d44f95978dfa97af04af00055dc3fbf7978 [2]: b5b6ab4194f16e96ee5004288cc469ac1bca41a3 --- bootstraptest/test_yjit.rb | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/bootstraptest/test_yjit.rb b/bootstraptest/test_yjit.rb index f30c5ff9000..18d1f85b934 100644 --- a/bootstraptest/test_yjit.rb +++ b/bootstraptest/test_yjit.rb @@ -2450,10 +2450,10 @@ assert_equal 'ok', %q{ https://github.com/ruby/ruby/blob/trunk/bootstraptest/test_yjit.rb#L2450 RubyVM::YJIT.simulate_oom! if defined?(RubyVM::YJIT) nimai(false) -} if false # disabled for now since OOM crashes in the test harness +} -# block invalidation while out of memory assert_equal 'new', %q{ + # test block invalidation while out of memory def foo :old end @@ -2472,7 +2472,7 @@ assert_equal 'new', %q{ https://github.com/ruby/ruby/blob/trunk/bootstraptest/test_yjit.rb#L2472 end test -} if false # disabled for now since OOM crashes in the test harness +} assert_equal 'ok', %q{ # Try to compile new method while OOM -- cgit v1.2.1 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/