[前][次][番号順一覧][スレッド一覧]

ruby-changes:69718

From: Yusuke <ko1@a...>
Date: Fri, 12 Nov 2021 16:42:53 +0900 (JST)
Subject: [ruby-changes:69718] 61938e2db5 (master): test/ruby/test_jit.rb: suppress a false-positive warning

https://git.ruby-lang.org/ruby.git/commit/?id=61938e2db5

From 61938e2db59a032a46fc3de2ebead2e5e9d630a9 Mon Sep 17 00:00:00 2001
From: Yusuke Endoh <mame@r...>
Date: Fri, 12 Nov 2021 16:40:49 +0900
Subject: test/ruby/test_jit.rb: suppress a false-positive warning

It reports "opt_regexpmatch2 insn is not included", but actually it is
included. This is due to a known bug of ISeq#to_a on which this check
depends.

https://bugs.ruby-lang.org/issues/18269
---
 test/ruby/test_jit.rb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/ruby/test_jit.rb b/test/ruby/test_jit.rb
index 669dcf56e6f..f7ea67c0238 100644
--- a/test/ruby/test_jit.rb
+++ b/test/ruby/test_jit.rb
@@ -1231,7 +1231,9 @@ class TestJIT < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_jit.rb#L1231
   end
 
   def mark_tested_insn(insn, used_insns:, uplevel: 1)
-    unless used_insns.include?(insn)
+    # Currently, this check emits a false-positive warning against opt_regexpmatch2,
+    # so the insn is excluded explicitly. See https://bugs.ruby-lang.org/issues/18269
+    if !used_insns.include?(insn) && insn != :opt_regexpmatch2
       $stderr.puts
       warn "'#{insn}' insn is not included in the script. Actual insns are: #{used_insns.join(' ')}\n", uplevel: uplevel
     end
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]