[前][次][番号順一覧][スレッド一覧]

ruby-changes:69702

From: Kazuki <ko1@a...>
Date: Thu, 11 Nov 2021 18:00:23 +0900 (JST)
Subject: [ruby-changes:69702] cd51bf61a2 (master): test/openssl/test_ssl: adjust certificate expiry date

https://git.ruby-lang.org/ruby.git/commit/?id=cd51bf61a2

From cd51bf61a2178a73219f7884792dfb82ca64c082 Mon Sep 17 00:00:00 2001
From: Kazuki Yamaguchi <k@r...>
Date: Thu, 11 Nov 2021 17:59:22 +0900
Subject: test/openssl/test_ssl: adjust certificate expiry date

test_connect_certificate_verify_failed_exception_message occasionally
fails. Is it possible that OpenSSL sees a different clock from Ruby by
more than 10 seconds?

http://ci.rvm.jp/logfiles/brlog.trunk-random0.20211111-072828

Let's give more time after the certificate expiration date to see if
this fixes the flakiness. We had similar occasional failures in
test_x509store.rb before, which disappeared after ruby/ruby commit
7930a352a57c and ruby/openssl commit fb2fcbb13734.
---
 test/openssl/test_ssl.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/test/openssl/test_ssl.rb b/test/openssl/test_ssl.rb
index 70c46a93474..ef9958aee5d 100644
--- a/test/openssl/test_ssl.rb
+++ b/test/openssl/test_ssl.rb
@@ -1002,8 +1002,9 @@ class OpenSSL::TestSSL < OpenSSL::SSLTestCase https://github.com/ruby/ruby/blob/trunk/test/openssl/test_ssl.rb#L1002
     }
 
     ctx_proc = proc { |ctx|
+      now = Time.now
       ctx.cert = issue_cert(@svr, @svr_key, 30, [], @ca_cert, @ca_key,
-                            not_before: Time.now-100, not_after: Time.now-10)
+                            not_before: now - 7200, not_after: now - 3600)
     }
     start_server(ignore_listener_error: true, ctx_proc: ctx_proc) { |port|
       store = OpenSSL::X509::Store.new
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]