[前][次][番号順一覧][スレッド一覧]

ruby-changes:69324

From: Justin <ko1@a...>
Date: Fri, 22 Oct 2021 03:34:06 +0900 (JST)
Subject: [ruby-changes:69324] d0cad8ad83 (master): [rubygems/rubygems] Re-enable `default_ignores` option for standard

https://git.ruby-lang.org/ruby.git/commit/?id=d0cad8ad83

From d0cad8ad83a72455c35afc5300f090c7742af007 Mon Sep 17 00:00:00 2001
From: Justin Searls <searls@g...>
Date: Thu, 21 Oct 2021 12:58:51 -0400
Subject: [rubygems/rubygems] Re-enable `default_ignores` option for standard

I am not sure why this flag was turned off (it wasn't explained in my commit message in 0365dc852767ae589376a7aad1fb129738e408b0 or in my PR in #4411).

Whatever the reason, without `default_ignores` turned on, most default CI configurations will immediately fail, as they most likely vendor and cache their dependencies under `vendor`, which will cause standard to run against all the vendored gems and (most likely) fail. I think we should remove this before this feature is released.

https://github.com/rubygems/rubygems/commit/677f74be48
---
 lib/bundler/templates/newgem/standard.yml.tt | 2 --
 1 file changed, 2 deletions(-)

diff --git a/lib/bundler/templates/newgem/standard.yml.tt b/lib/bundler/templates/newgem/standard.yml.tt
index e720f41031..9e88fbbe8b 100644
--- a/lib/bundler/templates/newgem/standard.yml.tt
+++ b/lib/bundler/templates/newgem/standard.yml.tt
@@ -1,4 +1,2 @@ https://github.com/ruby/ruby/blob/trunk/lib/bundler/templates/newgem/standard.yml.tt#L1
 # For available configuration options, see:
 #   https://github.com/testdouble/standard
-
-default_ignores: false
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]