ruby-changes:68894
From: Maxime <ko1@a...>
Date: Thu, 21 Oct 2021 08:15:06 +0900 (JST)
Subject: [ruby-changes:68894] 54312d777c (master): Disable local type tracking for now
https://git.ruby-lang.org/ruby.git/commit/?id=54312d777c From 54312d777cc22a52cfafcce0a0a20ed48375b82e Mon Sep 17 00:00:00 2001 From: Maxime Chevalier-Boisvert <maxime.chevalierboisvert@s...> Date: Tue, 6 Apr 2021 15:15:06 -0400 Subject: Disable local type tracking for now --- yjit_codegen.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/yjit_codegen.c b/yjit_codegen.c index af0522a493..60560b70c8 100644 --- a/yjit_codegen.c +++ b/yjit_codegen.c @@ -490,8 +490,8 @@ gen_getlocal_wc0(jitstate_t* jit, ctx_t* ctx) https://github.com/ruby/ruby/blob/trunk/yjit_codegen.c#L490 mov(cb, REG0, mem_opnd(64, REG0, offs)); // Write the local at SP - x86opnd_t stack_top = ctx_stack_push_local(ctx, local_idx); - //x86opnd_t stack_top = ctx_stack_push(ctx, TYPE_UNKNOWN); + //x86opnd_t stack_top = ctx_stack_push_local(ctx, local_idx); + x86opnd_t stack_top = ctx_stack_push(ctx, TYPE_UNKNOWN); mov(cb, stack_top, REG0); return YJIT_KEEP_COMPILING; @@ -555,9 +555,12 @@ gen_setlocal_wc0(jitstate_t* jit, ctx_t* ctx) https://github.com/ruby/ruby/blob/trunk/yjit_codegen.c#L555 // if (flags & VM_ENV_FLAG_WB_REQUIRED) != 0 jnz_ptr(cb, side_exit); + // NOTE: disabled for now since we don't have a good strategy + // for dealing with how blocks/closures can affect local types + // // Set the type of the local variable in the context - val_type_t temp_type = ctx_get_temp_type(ctx, 0); - ctx_set_local_type(ctx, local_idx, temp_type); + //val_type_t temp_type = ctx_get_temp_type(ctx, 0); + //ctx_set_local_type(ctx, local_idx, temp_type); // Pop the value to write from the stack x86opnd_t stack_top = ctx_stack_pop(ctx, 1); -- cgit v1.2.1 -- ML: ruby-changes@q... Info: http://www.atdot.net/~ko1/quickml/