[前][次][番号順一覧][スレッド一覧]

ruby-changes:68508

From: Nobuyoshi <ko1@a...>
Date: Sun, 17 Oct 2021 01:34:39 +0900 (JST)
Subject: [ruby-changes:68508] 5de6e25144 (master): Replace unpack with unpack1

https://git.ruby-lang.org/ruby.git/commit/?id=5de6e25144

From 5de6e25144b5c5c72bb9ee1980b976704e07f3d3 Mon Sep 17 00:00:00 2001
From: Nobuyoshi Nakada <nobu@r...>
Date: Sun, 17 Oct 2021 00:46:25 +0900
Subject: Replace unpack with unpack1

---
 tool/lib/test/unit.rb               | 14 +++++++-------
 tool/lib/test/unit/parallel.rb      |  2 +-
 tool/test/testunit/test_parallel.rb |  4 ++--
 3 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/tool/lib/test/unit.rb b/tool/lib/test/unit.rb
index fd3b19406c..3067809153 100644
--- a/tool/lib/test/unit.rb
+++ b/tool/lib/test/unit.rb
@@ -574,9 +574,9 @@ module Test https://github.com/ruby/ruby/blob/trunk/tool/lib/test/unit.rb#L574
           jobs_status(worker)
         when /^done (.+?)$/
           begin
-            r = Marshal.load($1.unpack("m")[0])
+            r = Marshal.load($1.unpack1("m"))
           rescue
-            print "unknown object: #{$1.unpack("m")[0].dump}"
+            print "unknown object: #{$1.unpack1("m").dump}"
             return true
           end
           result << r[0..1] unless r[0..1] == [nil,nil]
@@ -587,7 +587,7 @@ module Test https://github.com/ruby/ruby/blob/trunk/tool/lib/test/unit.rb#L587
           return true
         when /^record (.+?)$/
           begin
-            r = Marshal.load($1.unpack("m")[0])
+            r = Marshal.load($1.unpack1("m"))
 
             suite = r.first
             key = [worker.name, suite]
@@ -597,18 +597,18 @@ module Test https://github.com/ruby/ruby/blob/trunk/tool/lib/test/unit.rb#L597
               @records[key] = [worker.start_time, Time.now]
             end
           rescue => e
-            print "unknown record: #{e.message} #{$1.unpack("m")[0].dump}"
+            print "unknown record: #{e.message} #{$1.unpack1("m").dump}"
             return true
           end
           record(fake_class(r[0]), *r[1..-1])
         when /^p (.+?)$/
           del_jobs_status
-          print $1.unpack("m")[0]
+          print $1.unpack1("m")
           jobs_status(worker) if @options[:job_status] == :replace
         when /^after (.+?)$/
-          @warnings << Marshal.load($1.unpack("m")[0])
+          @warnings << Marshal.load($1.unpack1("m"))
         when /^bye (.+?)$/
-          after_worker_down worker, Marshal.load($1.unpack("m")[0])
+          after_worker_down worker, Marshal.load($1.unpack1("m"))
         when /^bye$/, nil
           if shutting_down || worker.quit_called
             after_worker_quit worker
diff --git a/tool/lib/test/unit/parallel.rb b/tool/lib/test/unit/parallel.rb
index 96aadf0249..db2d918331 100644
--- a/tool/lib/test/unit/parallel.rb
+++ b/tool/lib/test/unit/parallel.rb
@@ -107,7 +107,7 @@ module Test https://github.com/ruby/ruby/blob/trunk/tool/lib/test/unit/parallel.rb#L107
             case buf.chomp
             when /^loadpath (.+?)$/
               @old_loadpath = $:.dup
-              $:.push(*Marshal.load($1.unpack("m")[0].force_encoding("ASCII-8BIT"))).uniq!
+              $:.push(*Marshal.load($1.unpack1("m").force_encoding("ASCII-8BIT"))).uniq!
             when /^run (.+?) (.+?)$/
               _report "okay"
 
diff --git a/tool/test/testunit/test_parallel.rb b/tool/test/testunit/test_parallel.rb
index 297ff414ed..8207e71868 100644
--- a/tool/test/testunit/test_parallel.rb
+++ b/tool/test/testunit/test_parallel.rb
@@ -99,7 +99,7 @@ module TestParallel https://github.com/ruby/ruby/blob/trunk/tool/test/testunit/test_parallel.rb#L99
           break if /^p (.+?)$/ =~ buf
         end
         assert_not_nil($1, "'p' was not found")
-        assert_match(/TestA#test_nothing_test = \d+\.\d+ s = \.\n/, $1.chomp.unpack("m")[0])
+        assert_match(/TestA#test_nothing_test = \d+\.\d+ s = \.\n/, $1.chomp.unpack1("m"))
       end
     end
 
@@ -111,7 +111,7 @@ module TestParallel https://github.com/ruby/ruby/blob/trunk/tool/test/testunit/test_parallel.rb#L111
         end
         assert_not_nil($1, "'done' was not found")
 
-        result = Marshal.load($1.chomp.unpack("m")[0])
+        result = Marshal.load($1.chomp.unpack1("m"))
         assert_equal(5, result[0])
         pend "TODO: result[1] returns 17. We should investigate it" do
           assert_equal(12, result[1])
-- 
cgit v1.2.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]