[前][次][番号順一覧][スレッド一覧]

ruby-changes:68011

From: Nobuyoshi <ko1@a...>
Date: Thu, 16 Sep 2021 19:43:29 +0900 (JST)
Subject: [ruby-changes:68011] ddb32e6616 (master): [Bug #18173] Update loaded_features_index

https://git.ruby-lang.org/ruby.git/commit/?id=ddb32e6616

From ddb32e66160ab50849419ef7c7ac584913b79c34 Mon Sep 17 00:00:00 2001
From: Nobuyoshi Nakada <nobu@r...>
Date: Tue, 14 Sep 2021 00:57:05 +0900
Subject: [Bug #18173] Update loaded_features_index

If $LOADED_FEATURES is changed in the just required file, also the
index table needs to be updated before loaded_features_snapshot is
reset.  If the snapshot is reset without updating the table, the
name of the added feature will not be found.
---
 load.c                    |  1 +
 test/ruby/test_require.rb | 17 +++++++++++++++++
 2 files changed, 18 insertions(+)

diff --git a/load.c b/load.c
index 5fb805d..28c17e8 100644
--- a/load.c
+++ b/load.c
@@ -598,6 +598,7 @@ rb_provide_feature(VALUE feature) https://github.com/ruby/ruby/blob/trunk/load.c#L598
     }
     rb_str_freeze(feature);
 
+    get_loaded_features_index();
     rb_ary_push(features, rb_fstring(feature));
     features_index_add(feature, INT2FIX(RARRAY_LEN(features)-1));
     reset_loaded_features_snapshot();
diff --git a/test/ruby/test_require.rb b/test/ruby/test_require.rb
index 4ef08f8..401b274 100644
--- a/test/ruby/test_require.rb
+++ b/test/ruby/test_require.rb
@@ -839,6 +839,23 @@ class TestRequire < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/ruby/test_require.rb#L839
     }
   end
 
+  def test_provide_in_required_file
+    paths, loaded = $:.dup, $".dup
+    Dir.mktmpdir do |tmp|
+      provide = File.realdirpath("provide.rb", tmp)
+      File.write(File.join(tmp, "target.rb"), "raise __FILE__\n")
+      File.write(provide, '$" << '"'target.rb'\n")
+      $:.replace([tmp])
+      assert(require("provide"))
+      assert(!require("target"))
+      assert_equal($".pop, provide)
+      assert_equal($".pop, "target.rb")
+    end
+  ensure
+    $:.replace(paths)
+    $".replace(loaded)
+  end
+
   if defined?($LOAD_PATH.resolve_feature_path)
     def test_resolve_feature_path
       paths, loaded = $:.dup, $".dup
-- 
cgit v1.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]