[前][次][番号順一覧][スレッド一覧]

ruby-changes:67935

From: Nobuyoshi <ko1@a...>
Date: Sat, 11 Sep 2021 17:59:11 +0900 (JST)
Subject: [ruby-changes:67935] 952806cdec (master): Update comments for minitest

https://git.ruby-lang.org/ruby.git/commit/?id=952806cdec

From 952806cdecac2c275cf54392d3bf815ee746a063 Mon Sep 17 00:00:00 2001
From: Nobuyoshi Nakada <nobu@r...>
Date: Sat, 11 Sep 2021 17:37:49 +0900
Subject: Update comments for minitest

---
 tool/lib/test/unit.rb          |  8 --------
 tool/lib/test/unit/testcase.rb | 14 +++++++-------
 2 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/tool/lib/test/unit.rb b/tool/lib/test/unit.rb
index cb12024..8fa3e72 100644
--- a/tool/lib/test/unit.rb
+++ b/tool/lib/test/unit.rb
@@ -46,11 +46,6 @@ module Test https://github.com/ruby/ruby/blob/trunk/tool/lib/test/unit.rb#L46
 
   ##
   # Test::Unit is an implementation of the xUnit testing framework for Ruby.
-  #
-  # If you are writing new test code, please use MiniTest instead of Test::Unit.
-  #
-  # Test::Unit has been left in the standard library to support legacy test
-  # suites.
   module Unit
     ##
     # Assertion base class
@@ -1518,9 +1513,6 @@ module Test https://github.com/ruby/ruby/blob/trunk/tool/lib/test/unit.rb#L1513
 
       # Overriding of Test::Unit::Runner#puke
       def puke klass, meth, e
-        # TODO:
-        #   this overriding is for minitest feature that skip messages are
-        #   hidden when not verbose (-v), note this is temporally.
         n = report.size
         e = case e
             when Test::Unit::PendedError then
diff --git a/tool/lib/test/unit/testcase.rb b/tool/lib/test/unit/testcase.rb
index 6753d22..544628f 100644
--- a/tool/lib/test/unit/testcase.rb
+++ b/tool/lib/test/unit/testcase.rb
@@ -76,7 +76,7 @@ module Test https://github.com/ruby/ruby/blob/trunk/tool/lib/test/unit/testcase.rb#L76
     module LifecycleHooks
       ##
       # Runs before every test, after setup. This hook is meant for
-      # libraries to extend minitest. It is not meant to be used by
+      # libraries to extend Test::Unit. It is not meant to be used by
       # test developers.
       #
       # See #before_setup for an example.
@@ -85,12 +85,12 @@ module Test https://github.com/ruby/ruby/blob/trunk/tool/lib/test/unit/testcase.rb#L85
 
       ##
       # Runs before every test, before setup. This hook is meant for
-      # libraries to extend minitest. It is not meant to be used by
+      # libraries to extend Test::Unit. It is not meant to be used by
       # test developers.
       #
       # As a simplistic example:
       #
-      #   module MyMinitestPlugin
+      #   module MyTestUnitPlugin
       #     def before_setup
       #       super
       #       # ... stuff to do before setup is run
@@ -113,14 +113,14 @@ module Test https://github.com/ruby/ruby/blob/trunk/tool/lib/test/unit/testcase.rb#L113
       #   end
       #
       #   class Test::Unit::Runner::TestCase
-      #     include MyMinitestPlugin
+      #     include MyTestUnitPlugin
       #   end
 
       def before_setup; end
 
       ##
       # Runs after every test, before teardown. This hook is meant for
-      # libraries to extend minitest. It is not meant to be used by
+      # libraries to extend Test::Unit. It is not meant to be used by
       # test developers.
       #
       # See #before_setup for an example.
@@ -129,7 +129,7 @@ module Test https://github.com/ruby/ruby/blob/trunk/tool/lib/test/unit/testcase.rb#L129
 
       ##
       # Runs after every test, after teardown. This hook is meant for
-      # libraries to extend minitest. It is not meant to be used by
+      # libraries to extend Test::Unit. It is not meant to be used by
       # test developers.
       #
       # See #before_setup for an example.
@@ -141,7 +141,7 @@ module Test https://github.com/ruby/ruby/blob/trunk/tool/lib/test/unit/testcase.rb#L141
     # Subclass TestCase to create your own tests. Typically you'll want a
     # TestCase subclass per implementation class.
     #
-    # See MiniTest::Unit::AssertionFailedErrors
+    # See <code>Test::Unit::AssertionFailedError</code>s
 
     class TestCase
       include Assertions
-- 
cgit v1.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]