[前][次][番号順一覧][スレッド一覧]

ruby-changes:67437

From: David <ko1@a...>
Date: Tue, 31 Aug 2021 19:07:28 +0900 (JST)
Subject: [ruby-changes:67437] ab1edc75f8 (master): [rubygems/rubygems] Expect the right permissions on Windows

https://git.ruby-lang.org/ruby.git/commit/?id=ab1edc75f8

From ab1edc75f8afb9e147158a7b20743aaea92ce96e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?David=20Rodr=C3=ADguez?= <deivid.rodriguez@r...>
Date: Thu, 5 Aug 2021 09:53:02 +0200
Subject: [rubygems/rubygems] Expect the right permissions on Windows

Given Windows doesn't have executable bit.

https://github.com/rubygems/rubygems/commit/35dc3fa845
---
 spec/bundler/commands/binstubs_spec.rb | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/spec/bundler/commands/binstubs_spec.rb b/spec/bundler/commands/binstubs_spec.rb
index fb5da98..c8eef55 100644
--- a/spec/bundler/commands/binstubs_spec.rb
+++ b/spec/bundler/commands/binstubs_spec.rb
@@ -287,8 +287,6 @@ RSpec.describe "bundle binstubs <gem>" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/commands/binstubs_spec.rb#L287
     end
 
     it "sets correct permissions for binstubs" do
-      skip "https://github.com/rubygems/rubygems/issues/3352" if Gem.win_platform?
-
       with_umask(0o002) do
         install_gemfile <<-G
           source "#{file_uri_for(gem_repo1)}"
@@ -297,7 +295,7 @@ RSpec.describe "bundle binstubs <gem>" do https://github.com/ruby/ruby/blob/trunk/spec/bundler/commands/binstubs_spec.rb#L295
 
         bundle "binstubs rack"
         binary = bundled_app("bin/rackup")
-        expect(File.stat(binary).mode.to_s(8)).to eq("100775")
+        expect(File.stat(binary).mode.to_s(8)).to eq(Gem.win_platform? ? "100644" : "100775")
       end
     end
 
-- 
cgit v1.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]