[前][次][番号順一覧][スレッド一覧]

ruby-changes:67144

From: Takashi <ko1@a...>
Date: Sat, 14 Aug 2021 01:13:38 +0900 (JST)
Subject: [ruby-changes:67144] ee362302c0 (master): Revert "Pause an MJIT worker when JIT is cancelled"

https://git.ruby-lang.org/ruby.git/commit/?id=ee362302c0

From ee362302c0de8772b9f8be1b6c01c2f3aa40af04 Mon Sep 17 00:00:00 2001
From: Takashi Kokubun <takashikkbn@g...>
Date: Fri, 13 Aug 2021 09:13:09 -0700
Subject: Revert "Pause an MJIT worker when JIT is cancelled"

This reverts commit b64f81c81729bbc248d19af01cafde88eb60fdc7.

It seems to cause a problem in --jit / --jit-wait CIs. Reverting for now.
---
 NEWS.md | 2 --
 mjit.c  | 3 ---
 2 files changed, 5 deletions(-)

diff --git a/NEWS.md b/NEWS.md
index f727567..783f59c 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -182,8 +182,6 @@ Excluding feature bug fixes. https://github.com/ruby/ruby/blob/trunk/NEWS.md#L182
 * `--jit-verbose` and `--jit-warning` output "JIT cancel" when JIT-ed
   code is disabled because TracePoint or GC.compact is used.
 
-* Pause an MJIT worker when JIT-ed code gets disabled.
-
 * `RubyVM::MJIT` is renamed to `RubyVM::JIT`. [[Feature #17490]]
 
 ## Static analysis
diff --git a/mjit.c b/mjit.c
index bf2f26d..89f50cb 100644
--- a/mjit.c
+++ b/mjit.c
@@ -94,9 +94,6 @@ mjit_cancel_all(const char *reason) https://github.com/ruby/ruby/blob/trunk/mjit.c#L94
     if (mjit_opts.warnings || mjit_opts.verbose) {
         fprintf(stderr, "JIT cancel: Disabled JIT-ed code because %s\n", reason);
     }
-
-    // Currently we never re-enable JIT calls. Thus we don't need to run JIT anymore.
-    mjit_pause(false);
 }
 
 // Deal with ISeq movement from compactor
-- 
cgit v1.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]