[前][次][番号順一覧][スレッド一覧]

ruby-changes:67067

From: S.H <ko1@a...>
Date: Sat, 7 Aug 2021 12:51:07 +0900 (JST)
Subject: [ruby-changes:67067] 9b3fcfbbb9 (master): Suppress unused-result warnings

https://git.ruby-lang.org/ruby.git/commit/?id=9b3fcfbbb9

From 9b3fcfbbb9031036a9f7ba8ae1934f0805ea4d85 Mon Sep 17 00:00:00 2001
From: "S.H" <gamelinks007@g...>
Date: Sat, 7 Aug 2021 12:50:55 +0900
Subject: Suppress unused-result warnings

* Hide read function warning in string_spec_RSTRING_PTR_read function

* The type of `read` may be `ssize_t`

Co-authored-by: Nobuyoshi Nakada <nobu@r...>
---
 spec/ruby/optional/capi/ext/string_spec.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/spec/ruby/optional/capi/ext/string_spec.c b/spec/ruby/optional/capi/ext/string_spec.c
index b7bfcf8..feacbbd 100644
--- a/spec/ruby/optional/capi/ext/string_spec.c
+++ b/spec/ruby/optional/capi/ext/string_spec.c
@@ -397,12 +397,16 @@ VALUE string_spec_RSTRING_PTR_read(VALUE self, VALUE str, VALUE path) { https://github.com/ruby/ruby/blob/trunk/spec/ruby/optional/capi/ext/string_spec.c#L397
   rb_str_modify_expand(str, 30);
   rb_ary_push(capacities, SIZET2NUM(rb_str_capacity(str)));
   char *buffer = RSTRING_PTR(str);
-  read(fd, buffer, 30);
+  if (read(fd, buffer, 30) < 0) {
+    rb_syserr_fail(errno, "read");
+  }
 
   rb_str_modify_expand(str, 53);
   rb_ary_push(capacities, SIZET2NUM(rb_str_capacity(str)));
   char *buffer2 = RSTRING_PTR(str);
-  read(fd, buffer2 + 30, 53 - 30);
+  if (read(fd, buffer2 + 30, 53 - 30) < 0) {
+    rb_syserr_fail(errno, "read");
+  }
 
   rb_str_set_len(str, 53);
   close(fd);
-- 
cgit v1.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]