[前][次][番号順一覧][スレッド一覧]

ruby-changes:66686

From: Nobuyoshi <ko1@a...>
Date: Mon, 5 Jul 2021 18:35:33 +0900 (JST)
Subject: [ruby-changes:66686] 2f3edf28f3 (master): [ruby/rdoc] Prefer omit to pend

https://git.ruby-lang.org/ruby.git/commit/?id=2f3edf28f3

From 2f3edf28f3a251bac2cf3b47b46b372faac71e8e Mon Sep 17 00:00:00 2001
From: Nobuyoshi Nakada <nobu@r...>
Date: Mon, 28 Jun 2021 12:53:52 +0900
Subject: [ruby/rdoc] Prefer omit to pend

These conditions are not temporary, rather platform dependent.

https://github.com/ruby/rdoc/pull/815#discussion_r654660411

https://github.com/ruby/rdoc/commit/92545fa250
---
 test/rdoc/test_rdoc_rubygems_hook.rb | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/test/rdoc/test_rdoc_rubygems_hook.rb b/test/rdoc/test_rdoc_rubygems_hook.rb
index fb8dbd1..04f84d4 100644
--- a/test/rdoc/test_rdoc_rubygems_hook.rb
+++ b/test/rdoc/test_rdoc_rubygems_hook.rb
@@ -45,7 +45,7 @@ class TestRDocRubygemsHook < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/rdoc/test_rdoc_rubygems_hook.rb#L45
     begin
       RDoc::RubygemsHook.load_rdoc
     rescue Gem::DocumentError => e
-      pend e.message
+      omit e.message
     end
     @old_ui = Gem::DefaultUserInteraction.ui
     Gem::DefaultUserInteraction.ui = Gem::SilentUI.new
@@ -236,8 +236,8 @@ class TestRDocRubygemsHook < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/rdoc/test_rdoc_rubygems_hook.rb#L236
   end
 
   def test_remove_unwritable
-    pend 'chmod not supported' if Gem.win_platform?
-    pend "assumes that euid is not root" if Process.euid == 0
+    omit 'chmod not supported' if Gem.win_platform?
+    omit "assumes that euid is not root" if Process.euid == 0
 
     FileUtils.mkdir_p @a.base_dir
     FileUtils.chmod 0, @a.base_dir
@@ -266,8 +266,8 @@ class TestRDocRubygemsHook < Test::Unit::TestCase https://github.com/ruby/ruby/blob/trunk/test/rdoc/test_rdoc_rubygems_hook.rb#L266
   end
 
   def test_setup_unwritable
-    pend 'chmod not supported' if Gem.win_platform?
-    pend "assumes that euid is not root" if Process.euid == 0
+    omit 'chmod not supported' if Gem.win_platform?
+    omit "assumes that euid is not root" if Process.euid == 0
 
     FileUtils.mkdir_p @a.doc_dir
     FileUtils.chmod 0, @a.doc_dir
-- 
cgit v1.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]