[前][次][番号順一覧][スレッド一覧]

ruby-changes:66640

From: Yusuke <ko1@a...>
Date: Wed, 30 Jun 2021 11:47:00 +0900 (JST)
Subject: [ruby-changes:66640] db7e9b1aac (master): [ruby/error_highlight] Add some comments

https://git.ruby-lang.org/ruby.git/commit/?id=db7e9b1aac

From db7e9b1aac7752259e60e09b92ea2d2e74b0886d Mon Sep 17 00:00:00 2001
From: Yusuke Endoh <mame@r...>
Date: Wed, 30 Jun 2021 11:44:48 +0900
Subject: [ruby/error_highlight] Add some comments

https://github.com/ruby/error_highlight/commit/e0c90c72c3
---
 lib/error_highlight/core_ext.rb | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/error_highlight/core_ext.rb b/lib/error_highlight/core_ext.rb
index ad1c15a..0ca2d13 100644
--- a/lib/error_highlight/core_ext.rb
+++ b/lib/error_highlight/core_ext.rb
@@ -1,5 +1,8 @@ https://github.com/ruby/ruby/blob/trunk/lib/error_highlight/core_ext.rb#L1
 module ErrorHighlight
   module CoreExt
+    # This is a marker to let `DidYouMean::Correctable#original_message` skip
+    # the following method definition of `to_s`.
+    # See https://github.com/ruby/did_you_mean/pull/152
     SKIP_TO_S_FOR_SUPER_LOOKUP = true
     private_constant :SKIP_TO_S_FOR_SUPER_LOOKUP
 
@@ -42,7 +45,8 @@ module ErrorHighlight https://github.com/ruby/ruby/blob/trunk/lib/error_highlight/core_ext.rb#L45
 
   NameError.prepend(CoreExt)
 
-  # temporarily disabled
+  # The extension for TypeError/ArgumentError is temporarily disabled due to many test failures
+
   #TypeError.prepend(CoreExt)
   #ArgumentError.prepend(CoreExt)
 end
-- 
cgit v1.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]