[前][次][番号順一覧][スレッド一覧]

ruby-changes:66527

From: aycabta <ko1@a...>
Date: Mon, 21 Jun 2021 18:44:35 +0900 (JST)
Subject: [ruby-changes:66527] b06218ce6f (master): [ruby/reline] Remove TODO comment in #render_partial

https://git.ruby-lang.org/ruby.git/commit/?id=b06218ce6f

From b06218ce6ffdaf73d3668e760a34118021b978b5 Mon Sep 17 00:00:00 2001
From: aycabta <aycabta@g...>
Date: Wed, 2 Jun 2021 19:10:08 +0900
Subject: [ruby/reline] Remove TODO comment in #render_partial

https://github.com/ruby/reline/commit/bb6ea232c2
---
 lib/reline/line_editor.rb | 1 -
 1 file changed, 1 deletion(-)

diff --git a/lib/reline/line_editor.rb b/lib/reline/line_editor.rb
index 7d71e62..f2f5397 100644
--- a/lib/reline/line_editor.rb
+++ b/lib/reline/line_editor.rb
@@ -678,7 +678,6 @@ class Reline::LineEditor https://github.com/ruby/ruby/blob/trunk/lib/reline/line_editor.rb#L678
   private def render_partial(prompt, prompt_width, line_to_render, this_started_from, with_control: true)
     visual_lines, height = split_by_width(line_to_render.nil? ? prompt : prompt + line_to_render, @screen_size.last)
     cursor_up_from_last_line = 0
-    # TODO: This logic would be sometimes buggy if this logical line isn't the current @line_index.
     if @scroll_partial_screen
       last_visual_line = this_started_from + (height - 1)
       last_screen_line = @scroll_partial_screen + (@screen_height - 1)
-- 
cgit v1.1


--
ML: ruby-changes@q...
Info: http://www.atdot.net/~ko1/quickml/

[前][次][番号順一覧][スレッド一覧]